1611349 - Empty Add-On Preferences in menu bar (workaround, use APPmenu) on Mac

Status: RESOLVED INVALID

(Thunderbird :: Add-Ons: General, defect)

Description

[bugs]

Attachment: Screen Shot 2020-01-23 at 11.08.26 AM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

MacOS Catalina 10.15.2
Open Thunderbird. Tools > Add-on Preferences menu has no content.
Currently have three Extensions: Lightning, Send Later and SmartTemplate4

Actual results:

No content

Expected results:

Should see preferences for each Add-on

Comment 1

[WaltS48 [:walts48]]

I don't expect to see preferences for Lightning. Those haven't been there for awhile now.

The others show in Tools > Add-on Preferences for me after I installed them in 68.4.1 using a test profile on Ubuntu 18.04.3 Linux.

The Folders and Message Lists component is for problems with the Folder and Thread Panes, not the add-ons or menus. So I moved this bug to the Add-Ons: General component.

Comment 2

[sfhowes]

See https://support.mozilla.org/en-US/questions/1278185 for workaround.

Comment 3

[Elhem Enohpi]

I can confirm the same behaviour on macOS Mojave 10.14.6 and Thunderbird 68.5.0. Is it a macOS-only problem?

Addons are Compact Header 3.0.0b5, Filtaquilla 2.0, and Maximize Message Pane 1.3.0. The Mac's menubar item "Tools > Add-on Preferences" submenu at first says "No Add-on settings found" and then subsequently does not display. However, preferences can be accessed via the "AppMenu > Add-ons" item, if it's installed in the Mail Toolbar.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

Comment 4

[[e-mail]]

I confirm the same issue on macOS Mojave 10.14.6 and Thunderbird 68.6.0.
I have tested large number of addons, even ones that are given as examples of correct implementation, for example Shrunked Image Resizer.
Currently addons installed are ReplyWithHeader, Shrunken, ImportExportTools NG, Tag Toolbar.
None if them appears in Tools->Add-on Preferences menu.
Workaround described above (via App menu) still works, see attached image.
It seems that this bug is related to MacOSX only, Windows users reported menu working, while MacOSX - not, see for example:
https://myjeeva.com/replywithheader-mozilla
Menu on MacOSX is handled quite differently than on Linux or Windows, so something is broken here.
I have checked error console - there are some errors, however, no probably, they are not related to the. No errors appears when I try to open Tools->Add-on Preferences.
I also noticed, that ImportExportTools NG implemented custom entry to Tools menu, Options dialog is moved here, and it works. Still, IET-NG Options entry does not appear on Add-on Preferences.

Comment 5

[[e-mail]]

Attachment: App menu populated with options

Comment 6

[Wayne Mery (:wsmwk)]

should be easy to ferret out?

Comment 7

[Wayne Mery (:wsmwk)]

Any good reason why this might be happening for Mac only (which is not good for new users)

Comment 8

[:Dossy Shiobara]

Attachment: Screenshot of Error Console warning from omni.ja!/modules/Overlays.jsm:195

Any chance this error in the Error Console is related?

Edited to add: Looks like this is caused by the Mail Redirect extension (https://mailredirect.sourceforge.io/) - when I disabled the extension and restarted TB, this warning went away - but the bug behavior didn't go away.

Comment 9

[:Dossy Shiobara]

Attachment: Screenshot of Error Console error from omni.ja!/chrome/messenger/content/messenger/msgViewPickerOverlay.js:98:9

Could this be related?

Edited to add: Seems unlikely, this looks like it's the "View:" filter functionality.

Comment 10

[:Dossy Shiobara]

Not sure if this useful diagnostics, but I disabled ALL extensions, restarted TB, and the "Tools > Add-on Preferences" shows (as expected) "No Add-on settings found." and dismissing it and re-navigating to it shows it again, as expected.

I then enabled the Enigmail add-on, restarted TB, and only the first time accessing the "Tools > Add-on Preferences" menu showed the "No Add-on settings found." submenu - dismissing it and re-navigating to it results in no sub-menu displayed.

I disabled Enigmail again, and then enabled Lightning extension, restarted TB, and the "Tools > Add-on Preferences" shows the "No Add-on settings found." submenu, but dismissing it and re-navigating to it continues to show it each time.

I wonder what the difference is between the two extensions that causes one to "break" the submenu from displaying after the first time, while the other doesn't.

Also, using the hamburger menu and selecting "Add-ons" only shows Enigmail as having add-on preferences. I suppose this might be why having Lightning enabled doesn't "break" the sub-menu display like Enigmail does.

Comment 11

[Magnus Melin [:mkmelin]]

I don't think that menu exists anymore on 78. (I do notice addonPrefsUnix.label was left in, but not used anywhere).
So this is probably wontfix.

Comment 12

[Richard Marti (:Paenglab)]

The main menu treatment is different to the other platforms. And yes, with TB 78 this menus no more exists.

Comment 13

[[e-mail]]

I could not find any way to change Add-on properties on TB 78. Even "hamburger" menu entry is no longer available. Is the current plan to disable all Addons in TB 78? If not, I think it is necessary to fill bug for TB 78 that Add-on preference s menu is no longer accessible.

Comment 14

[Magnus Melin [:mkmelin]]

Add-ons are supported, but they are required to implement their own preferences handling. (Like for Firefox.)

Comment 15

[[e-mail]]

That is sad news for add-on developers. TB 68 already broke down addons once and re-write was required. TB 78 seems to be following the same route.
Are non-compatibility already announced? Are there any guidelines what to do next? All I can find with google is https://developer.thunderbird.net/add-ons/updating/tb78 . This seems to be outdated since it does not mention anything about preferences menu.

Comment 16

[Wayne Mery (:wsmwk)]

John, can you remedy comment 15

Comment 17

[John Bieling (:TbSync)]

Regarding the update guide, we are currently working on it (https://github.com/thundernest/developer-docs/pull/73)

Regarding the missing add-on preferences as reported by the bug creator in TB 68: I do not know, if this is a regression. In TB 68.9 I get the entries in the Add-On Settings Menu for TbSync and for EditEmailSubject, which I have currently installed. I am on Windows. So that looks fine to me.

In TB 78 this menu indeed no longer exists, which I have not noticed so far. If the addon has been properly converted to TB78 (which means you have an options_ui entry in the manifest), than Addons can be configured in the Add-On Manager. Like with the not-yet-released version of my CategoryManager (attachment CM1 and CM2). Sorry for the german locale, "Einstellungen" = "Settings" or "Options".

Is the missung menu intentional?

Comment 18

[John Bieling (:TbSync)]

Attachment: CM1.PNG

Comment 19

[John Bieling (:TbSync)]

Attachment: CM2.PNG