Closed
Bug 162068
Opened 22 years ago
Closed 22 years ago
Fix callers of ThrowUserError to use messages.html.tmpl
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: gerv, Assigned: gerv)
Details
Attachments
(1 file, 1 obsolete file)
25.91 KB,
patch
|
bbaetz
:
review+
bbaetz
:
review+
|
Details | Diff | Splinter Review |
We need to fix the callers of ThrowUserError so their strings get moved into the templates. (see also bug 162066.) Gerv
Assignee | ||
Comment 1•22 years ago
|
||
This fixes all call sites. Gerv
Assignee | ||
Updated•22 years ago
|
Comment 2•22 years ago
|
||
Comment on attachment 94762 [details] [diff] [review] Patch v.1 You left out Bugzilla/Search.pm. That code should probably return an error, rather than dump to a tempalte directly, but thats a separate issue Also, the " in the invalid_email_address thing should be "
Assignee | ||
Comment 3•22 years ago
|
||
Review comments addressed. Gerv
Attachment #94762 -
Attachment is obsolete: true
Comment 4•22 years ago
|
||
Comment on attachment 95370 [details] [diff] [review] Patch v.2 Remove the default case at the end (or make it print a sensible internal error string), and r=bbaetz x2. I didn't test this, but it looks right, and I presume you have...
Attachment #95370 -
Flags: review+
Assignee | ||
Comment 5•22 years ago
|
||
Fixed. Checking in CGI.pl; /cvsroot/mozilla/webtools/bugzilla/CGI.pl,v <-- CGI.pl new revision: 1.167; previous revision: 1.166 done Checking in duplicates.cgi; /cvsroot/mozilla/webtools/bugzilla/duplicates.cgi,v <-- duplicates.cgi new revision: 1.23; previous revision: 1.22 done Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.190; previous revision: 1.189 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.137; previous revision: 1.136 done Checking in template/en/default/global/messages.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v <-- messages.html.tmpl new revision: 1.5; previous revision: 1.4 done Checking in Bugzilla/Search.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v <-- Search.pm new revision: 1.5; previous revision: 1.4 done Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•