163541 - header.html.tmpl should set h1 be the empty string

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

header.html.tmpl currently doesn't let the primary page header (h1) be the empty
string, because the DEFAULT directive thinks "" == undefined and sets h1 = title
in that case.  This causes problems with, f.e. setting a title on the custom
b.m.o index page without that title appearing as the primary page header.

header.html.tmpl should let the calling template specify that h1 is empty.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

This patch handles h1 outside the DEFAULT tag to avoid DEFAULT doing the wrong
thing.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

This patch has been applied to b.m.o.

Comment 3

[Gervase Markham [:gerv]]

Is this behaviour as designed, or a bug? And if the latter, have we reported it?

Gerv

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 95916 [details] [diff] [review]
patch v1: fixes problem

looks reasonable

r=bbaetz x2

Comment 5

[Myk Melez [:myk] [@mykmelez]]

This is behavior as designed.

Checking in header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.16; previous revision: 1.15
done

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Reopening.  Something strange is going on.  On my local install this patch works
fine, but on b.m.o. it makes primary headers stop appearing.  Changing the
conditional from the shortcut form to the classic form makes it work:

[% h1 = title IF !h1.defined %] --> [% IF !h1.defined %][% h1 = title %][% END %]

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: changes conditional structure

Comment 8

[Bradley Baetz (:bbaetz)]

Comment on attachment 95997 [details] [diff] [review]
patch v2: changes conditional structure

Really odd.

r=bbaetz x2

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.17; previous revision: 1.16
done

Comment 10

[GavinS]

(In reply to comment #3)
> Is this behaviour as designed, or a bug? And if the latter, have we reported
> it?
> 
> Gerv
> 

Was there ever a response to this?