Closed Bug 166481 Opened 22 years ago Closed 22 years ago

Spellcheck is borked.

Categories

(Bugzilla :: Testing Suite, defect)

2.15
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: CodeMachine, Assigned: zach)

References

Details

Attachments

(2 files)

Spellcheck needs updates.

Firstly, I wanted to add new words:

paramater (parameter) (I saw this in a patch somewhere)
existance (existence) (common)
existant (existent)

When I tested this, I discovered that spellcheck wasn't finding these
misspellings.  As it happens, only the first misspelling in the list is
successfully located.  This seems to be because the file isn't being reopened
between the misspellings.

Furthermore, spellcheck should check every file in the CVS tree for
misspellings, including the documentation, not just Perl scripts.  You can
exclude data and graphs, but everything else is fair game really.
Also $found_word isn't initialised first time through so I got uninit errors.
Here's a fix to the uninit variable and lack of reopening.  It will break tbox
so the spelling errors need to be corrected first.

It doesn't yet make the test check all files.
Target Milestone: --- → Bugzilla 2.18
Depends on: 166766
Attachment #97724 - Flags: review+
Flags: approval?
*** Bug 162224 has been marked as a duplicate of this bug. ***
Attachment #110188 - Flags: review+
Flags: approval? → approval+
zach: ping.  This was approved for checkin a week ago.  Hope it hasn't bitrotted :)
never! with my advanced project management methods, my patches never go stale!

Fix checked in (both patches)
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: