166690 - Remove Messages column in Subscribe.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P4)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: 2002-09-04-08, All OSs.

Summary: Remove Messages column in Subscribe.

Per the spec, we currently have the Messages column in Subscribe for News.

The problem is, it doesn't do anything, and isn't planned for implementation
anytime soon (correct me if I'm wrong).

I've got a patch to rip it out.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot of Modern

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot of Classic.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix

Comment 4

[jglick]

If it doesn't do anything, yes, please remove it. If there is any chance it 
might get implemented in the future, please file a separate bug so it can be 
tracked. Thanks. 

Comment 5

[(not reading, please use [e-mail] instead)]

you are right.

news gets no love, and won't for a while.

can you comment out the xul instead of removing it, refer to a new bug (or find
the existing bug) for "implement message count in subscribe"?

I think you should remove this splitter as well:

             <splitter class="tree-splitter"/>
-            <treecol id="messagesColumn" persist="hidden"
label="&messagesHeader.label;"
-                     sort="?TotalMessages"/>

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix, addresses Seth's comments.

Removes extraneous splitter, comments out code instead of removing it.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Patch, 'final' version. It helps to attach the correct patch.

Sorry, this really is it.

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

The bug for implementing message counts is bug 38906.  Do we want that in the
comments of Subscribe.xul/Subscribe.dtd?

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Yet Another Patch. Comments out the Search view's splitter, too.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Should be final, was tested on Classic/Modern, tree and flat view of Subscribe.

Comment 11

[Jan Varga [:janv]]

Comment on attachment 97850 [details] [diff] [review]
Should be final, was tested on Classic/Modern, tree and flat view of Subscribe.

r=varga

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 97850 [details] [diff] [review]
Should be final, was tested on Classic/Modern, tree and flat view of Subscribe.

sr=sspitzer

affects end users positively, has UI approval from jglick.

thanks for cleaning up my mess, hammer.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 97850 [details] [diff] [review]
Should be final, was tested on Classic/Modern, tree and flat view of Subscribe.

a=asa (on behalf of drivers) for checkin to 1.2a

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Fix landed on the trunk.  Thanks to all!  QA over to Karen, because I won't QA
my own fixes.

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

Can't verify my own bugs --> gary

Comment 16

[esther]

Using trunk build 20030218 on winxp, maco osx and linux this is fixed. Verified.