169561 - Speed up UserInGroup by using cached information

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Gervase Markham [:gerv]]

UserInGroup currently does a DB lookup. We already have all the information we
need to answer the UserInGroup question, because we found it out and stashed it
away in $vars->{'user'}{'groups'} in the GetUserInfo() sub in CGI.pl, which is
always executed.

So, UserInGroup should use this information instead of accessing the DB.
Hopefully this should speed things up a bit, as this is a frequently-called
function.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Simple, yet effective :-)

Gerv

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 99741 [details] [diff] [review]
Patch v.1

Looks good, works. r=myk

Comment 3

[Myk Melez [:myk] [@mykmelez]]

It's trivial, but since it affects security, this should get a second pair of
eyes on it.

Comment 4

[Gervase Markham [:gerv]]

Joel's our groups man :-) Joel: does this look sane to you? I know you are
probably rewriting this stuff, but anyway...

Gerv

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 99741 [details] [diff] [review]
Patch v.1

Eww. 'global variables are bad'.

OTOH, we can't get rid of $vars until we have a User.pm anyway. Hmm....

Yeah, this probably is OK for now, but please don't go arround changing
everywhere else.

Joel should look at this, anyway.

Comment 6

[Joel Peshkin]

Comment on attachment 99741 [details] [diff] [review]
Patch v.1


This is fine.  It will actually even still work after the groups stuff is in
because GetUserInfo will populate the user hash as before.

Comment 7

[Gervase Markham [:gerv]]

Fixed.

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.201; previous revision: 1.200
done

Gerv