171228 - [DHTML] Dragging is broken

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Kevin McCluskey (gone)]

The checkin for bug 104934 broke dragging of elements on www.dhtmlcentral.com.

1. load http://dhtmlcentral.com/
2. Click on hold down on one of the "windows" on dhtmlcentral and drag it to a
new position.
3. It will only draw the window after you stop moving the mouse.
4. prior to this checkin the window would smoothly display as the mouse is
dragged around.

If I back out the change for bug 104934 in my local tree the problem goes away:

cvs update -j3.7 -j3.6 mozilla/widget/src/windows/Makefile.in
cvs update -j1.41 -j1.40 mozilla/widget/src/build/Makefile.in

Comment 1

[Roy Yokoyama]

i'll take a look

Comment 2

[Kevin McCluskey (gone)]

Resolving as fixed since I backed out changes for bug 104934

Comment 3

[Roy Yokoyama]

reopening. 
I am going to put back 104934.

Comment 4

[Kevin McCluskey (gone)]

Roy: Can you look at why drag is broken by the patch for bug 104934 before
putting it back in?

Comment 5

[Roy Yokoyama]

kevin: No worries. That's my original plan.  I will post a patch to
       fix _this_ particular problem and get r=/sr= before putting
       the switch back in.

Comment 6

[Roy Yokoyama]

Hmmm calls to SetWindowLongW() causes this dragging problem.
Investigating....

Comment 7

[Roy Yokoyama]

Attachment: Need nsToolkit::mGetWindowLong

shanjian: can you review?

Comment 8

[Shanjian Li]

Comment on attachment 102497 [details] [diff] [review]
Need nsToolkit::mGetWindowLong

Looks fine. r=shanjian

Comment 9

[kinmoz]

Comment on attachment 102497 [details] [diff] [review]
Need nsToolkit::mGetWindowLong

sr=[e-mail], though I wish we did what I proposed in bug 141630 comment
6, earlier on:

  http://bugzilla.mozilla.org/show_bug.cgi?id=141630#c6

I really dislike the fact that we are adding more and more of these ifdefs
where the only differences are the nsToolkit:: prefix.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 102497 [details] [diff] [review]
Need nsToolkit::mGetWindowLong

a=asa for checkin to 1.2beta (on behalf of drivers)

Comment 11

[Roy Yokoyama]

fix checked into the trunk
Please verify once we turn the MOZ_UNICODE flag on by default
or provide a special unicode build (whichever comes first)

Comment 12

[Trix Supremo]

verified on latest trunk build 2002122608