171420 - faulty use of local variables in Flag.pm

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Flag.pm uses $vars sometimes when it needs $::vars, and it contains a reference
to &Param that should be &::Param (which actually causes a software error).

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problems

Comment 2

[Bradley Baetz (:bbaetz)]

Comment on attachment 101009 [details] [diff] [review]
patch v1: fixes problems

|use Bugzilla::Config| (and drop the &) and |use vars| instead

Comment 3

[Bradley Baetz (:bbaetz)]

*** Bug 171474 has been marked as a duplicate of this bug. ***

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: uses "Bugzilla::Config"

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 101039 [details] [diff] [review]
patch v2: uses "Bugzilla::Config"

r=bbaetz x2

Long live Bugzilla::Template!

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.2; previous revision: 1.1
done