174163 - Unselecting image shows it in reverse-video

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: 2002-10-04-08 linux trunk build

STEPS TO REPRODUCE:

1)  Load http://www.mozilla.org/
2)  Hit tab
3)  Hit tab (this focuses the mozilla.org logo)
4)  Hit shift-tab

EXPECTED RESULTS: Image is shown normally now that it is no longer focused

ACTUAL RESULTS:  Image is shown in reverse-video

Curiously, tabbing _forward_ off the image works just fine.

The same problem occurs on http://web.mit.edu/ with a jpeg, so this is a problem
with at least gifs and jpegs.

Comment 1

[mjudge]

Attachment: fix for tabbing from mozilla dir

I could have sworn this was in the trunk but its not.  I need to find the
actual bug on this.  probably was resolved.  This patch removes the dependance
of tabbing on selection.  (except of course after a find or purposeful
selection move)  Give it a try see if it fixes your problem.  I will test it
myself

Comment 2

[mjudge]

yes this fixes your issue.  I cant find the old bug and I will try to use this
one to get it into the tree.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah, that seems to work.... (is it time to move to PRPackeBool for some of
those member vars yet?)

Comment 4

[José Jeria]

Will this also fix this behavior?

Go to:
http://www.mozilla.org/start/1.0/demos/eagle-sun.html

Drag around the sun or the eagle. The image gets selected sometimes.

Comment 5

[mjudge]

it should select the sun

Comment 6

[José Jeria]

What is the logic of that? Is it because its the default behavior of an image?

The eagle get selected only when over the text or the sun. And also if you drag
it really fast and up and down.

Adding e.preventDefault(); helps. But then the code for this example is no good
anymore (you loose the image when you drag it), because the onmousemove is set
to the img and not to the document.

Comment 7

[mjudge]

I am not sure what you are saying here. in i.e. also if you draw select across
the image of the sun, the sun looks selected.  can you post a screenshot of what
you consider a problem?

Comment 8

[José Jeria]

Attachment: Pic showing selection

This screenshot shows what I mean, drag around the eagle, it gets dragged
(surprise), but only when there are other images on the same position, like the
sun in this case, the eagle image gets selected. Dragging it out of the sun
removes the selection of the eagle. 
For me this does not make much sense.

Comment 9

[R.K.Aa.]

the problem with the eagle/sun demo was just filed as bug 191356

Comment 10

[José Jeria]

Will the patch be checked in for 1.3?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 103063 [details] [diff] [review]
fix for tabbing from mozilla dir

Not unless it gets some reviews....

Comment 12

[Brian Ryner (not reading)]

Comment on attachment 103063 [details] [diff] [review]
fix for tabbing from mozilla dir

(I'm deferring sr on this until aaronl has had a chance to look at it).

Comment 13

[Aaron Leventhal]

I think this is the right fix. Although I'm not sure what regressions it might
cause, I think we should do it, because it's better this way.

However, we should be able to completely get rid of MoveCaretToFocus() if we do
this, right?

Also, as Mike and I discussed, we don't want this in nsPresShell.cpp:
-  mSelectionFlags = nsISelectionDisplay::DISPLAY_TEXT |
nsISelectionDisplay::DISPLAY_IMAGES;
+  mSelectionFlags = nsISelectionDisplay::DISPLAY_ALL;

It could have some bad side effects, because there are places that look at
mSelectionFlags to see if something's an editor window.

Mike, can you post a new patch updated to the trunk with those changes?

Comment 14

[Aaron Leventhal]

I'm not seeing the original test case with www.mozilla.org in this bug happen.

I am seeing bug 170921 with image maps though. This patch also fixes that.

Perhaps this should be marked worksforme. The work for bug 170921 can continue
in there.

Comment 15

[Aaron Leventhal]

checked in as part of bug 170921

Comment 16

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.03.13 comm trunk on all platforms.