Closed Bug 174831 Opened 22 years ago Closed 22 years ago

invisible/missing collapsed twisty (expand arrow, folder caret) in trees (mailnews 3pane, history, bookmarks)

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: tor)

References

Details

(Keywords: regression)

Attachments

(4 files)

twisties visible when expanded
49.78 KB, image/png
Details
twisties invisible when collapsed
47.33 KB, image/png
Details
how many ways can a simple loop control be wrong? -fix
729 bytes, patch
paper
: review+
bzbarsky
: superreview+
blizzard
: approval+
Details | Diff | Splinter Review
Small view of missing 'twisty' expand arrow
14.51 KB, image/gif
Details 
found using 2002.10.15.08 comm trunk build on linux rh7.2. strangely, not a
problem on win2k. occurred with existing and new profiles.

open mailnews 3pane, and collapse any open twisties in the folder or thread
pane. notice that that while visible when expanded, the twisties become
invisible when collapsed.
this is toolkit, actually, since i see this in trees in bookmarks and history.
Assignee: sspitzer → jaggernaut
Component: Mail Window Front End → XP Toolkit/Widgets
Product: MailNews → Browser
QA Contact: olgam → jrgm
i had originally seen this using the modern theme. but i don't see this problem
with the classic theme.

let me know if this should be moved to the Themes component...
looked at checkins, I don't see any likely candidates yet.

I have nothing to back this up, but could it be bz's change: 

"Add & implement imgIContainer::ResetAnimation. Bug 152756, patch by
paper@animecity.nu (Arron), r=pavlov, sr=tor, a=asa"
Summary: collapsed twisties in 3pane are invisible → collapsed twisties in trees (mailnews 3pane, history, bookmarks) are invisible
Arron?  Any ideas?

Was this not a problem in Oct 14 builds?
not a problem with 2002.10.14.08 comm trunk build.
Keywords: regression
also reported in bug 174668 and bug 174735   
*** Bug 174668 has been marked as a duplicate of this bug. ***
Bug 152756 was checked in on the 10th.  We would have heard problems earlier. :)

Sounds like it could be caused by either Bug 142334, or Bug 174259
Blocks: 1.2
OK.  Backing out the bug  174259 patch fixes this.
Assignee: jaggernaut → tor
so... as I load a directory view, with lots of twisties of all sorts, here's the
sort of output I get from a 

  fprintf(stderr, "leftindex: %u; rightindex: %u;\n", leftindex, rightindex);
  fprintf(stderr, "left: %u; right: %u;\n", left, right);

inserted before the for loop in question:

leftindex: 0; rightindex: 1;
left: 0; right: 16;
leftindex: 0; rightindex: 3;
left: 0; right: 32;
leftindex: 0; rightindex: 0;
left: 0; right: 8;
leftindex: 0; rightindex: 0;
left: 0; right: 10;

So for a lot of these the loop would never even run; for the rest it would run
many fewer times than it used to.
i had wondered whether the gtk native theme checkin (bug 142334) would be
suspect. but when i tested it with the modern theme (using the
2002.10.14.13-NATIVE_THEME build), i didn't see this problem.
Comment on attachment 103095 [details] [diff] [review]
how many ways can a simple loop control be wrong? -fix

sr=bzbarsky.  Tested this, and it does the right thing, too.  ;)
Attachment #103095 - Flags: superreview+
Comment on attachment 103095 [details] [diff] [review]
how many ways can a simple loop control be wrong? -fix

r=paper
Attachment #103095 - Flags: review+
> looked at checkins, I don't see any likely candidates yet.
> I have nothing to back this up, but could it be bz's change: 

sorry for pointing the finger at the wrong person (my apologies to bz and arron)

thanks to tor for the quick fix!
Blocks: 1.2b
*** Bug 174944 has been marked as a duplicate of this bug. ***
Thanks for the fix, this bug is really annoying.


Has the fix been checked in ? I just pulled and build cvs 20021017 and
i still can't see the arrows in preferences or mail folder pane.

Also, please change the platform/os to all/all since i see this happens
on Solaris too.
*** Bug 174990 has been marked as a duplicate of this bug. ***
*** Bug 175010 has been marked as a duplicate of this bug. ***
>Also, please change the platform/os to all/all

this is a gtk-only bug, so it's not all/all.

also, it's probably not yet checked in, because it doesn't have approval yet.
Comment on attachment 103095 [details] [diff] [review]
how many ways can a simple loop control be wrong? -fix

a=blizzard on behalf of drivers for 1.2
Attachment #103095 - Flags: approval+
*** Bug 175057 has been marked as a duplicate of this bug. ***
*** Bug 175039 has been marked as a duplicate of this bug. ***
expanding summary, hoping to catch duplicates before they get created :)
Summary: collapsed twisties in trees (mailnews 3pane, history, bookmarks) are invisible → invisible/missing collapsed twisty (expand arrow, folder caret) in trees (mailnews 3pane, history, bookmarks)
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
*** Bug 175091 has been marked as a duplicate of this bug. ***
*** Bug 175176 has been marked as a duplicate of this bug. ***
verified with linuc commercial trunk build 2002-10-18-08-trunk
Status: RESOLVED → VERIFIED
This probably also fixes lack of Sidebar Close button in Modern theme - in
20021016 build there's just empty box and it reappears in 20021018 build.
(Couldn't find any  bugs for that).
*** Bug 175434 has been marked as a duplicate of this bug. ***
*** Bug 175840 has been marked as a duplicate of this bug. ***
*** Bug 175856 has been marked as a duplicate of this bug. ***
*** Bug 175901 has been marked as a duplicate of this bug. ***
*** Bug 176724 has been marked as a duplicate of this bug. ***
*** Bug 176199 has been marked as a duplicate of this bug. ***
*** Bug 175687 has been marked as a duplicate of this bug. ***
*** Bug 177861 has been marked as a duplicate of this bug. ***
*** Bug 178833 has been marked as a duplicate of this bug. ***
*** Bug 179324 has been marked as a duplicate of this bug. ***
*** Bug 179852 has been marked as a duplicate of this bug. ***
*** Bug 180035 has been marked as a duplicate of this bug. ***
*** Bug 180093 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: