175625 - Timetracking columns are computed even if not displayed

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Joel Peshkin]

When a user is capable of timetracking, the E/A/R columns are built into the
buglist queries even for queries that are not trying to display that data.  This
is a major perfomance hit for some queries.

These columns should only be computed if needed for the display or search criteria

Comment 1

[David Lawrence [:dkl]]

The columns are removed only if not a member of the timetracking group. I agree
that they should only be added if the time stuff is selected in colchange.cgi.
Also there is a bug in the time code in buglist.cgi.

# remaining and actual_time are required for precentage_complete calculation:
if (lsearch(\@displaycolumns, "percentage_complete")) {
    push (@selectcolumns, "remaining_time");
    push (@selectcolumns, "actual_time");
}

should be

# remaining and actual_time are required for precentage_complete calculation:
if (lsearch(\@displaycolumns, "percentage_complete") >= 0) {
    push (@selectcolumns, "remaining_time");
    push (@selectcolumns, "actual_time");
}

Comment 2

[Jeff Hedlund]

Attachment: Patch v.1

That should do it, it all stemmed from that bug.  

Thanks for the catch.

Comment 3

[Joel Peshkin]

Comment on attachment 103595 [details] [diff] [review]
Patch v.1

2xr=joel

Comment 4

[Joel Peshkin]

Checked in for Jeff.

Checking in buglist.cgi;                                     
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.203; previous revision: 1.202
done