Closed Bug 176715 Opened 22 years ago Closed 21 years ago

fails to import internet explorer bookmarks

Categories

(SeaMonkey :: Bookmarks & History, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.4alpha

People

(Reporter: sjm, Assigned: janv)

References

Details

(Keywords: dataloss, regression, Whiteboard: [adt2])

Attachments

(1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021024
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021024

Having installed a fresh copy of either 1.2b or the latest nightly build,
scrolling down to Imported IE Favorites displays only (Empty). However, some of
my IE bookmarks do appear under SmartFind queries.

When I restart Mozilla, Imported IE Favorites doesn't even display (Empty) and
the IE favourites that previously appeared under SmartFind queries are no longer
there.

I'm logged in as Administrator so permissions shouldn't be a problem.


Reproducible: Always

Steps to Reproduce:
1. 
2. 
3.
Could be related to bug 151104
*** Bug 177281 has been marked as a duplicate of this bug. ***
Confirming based on duplicate
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 120814
Nominating for Mozilla 1.2
Keywords: mozilla1.2
Keywords: regression
Severity: normal → major
*** Bug 175552 has been marked as a duplicate of this bug. ***
Keywords: nsCatFood
Me too.  I am using Win98se and XP-SP1 and Mozilla 1.2b on both.  Maybe it's the
weird location of the IE favorites folder.  On my Win98se network the favorites
folder is on a network drive (n:\mywork\appdata\favorite) and on my c: drive on
my XP PC (c:\documents and settings\"user"\favorites).

I re-installed Mozilla 1.1 and the imported favourites appeared.  Problem with
1.2b I think. 

Sorry if I am missing something obvious.  I am a newbie Mozilla user.  Like what
I see so far.
*** Bug 178928 has been marked as a duplicate of this bug. ***
Keywords: mozilla1.3
How to reproduce:
1. Create new profile.
2. Start Mozilla, no IE Favorites.

So when 1.2 is released this will affect mainly new users to Mozilla.
here is a workaround, what do you think of it ?

as I see things, importing bookmarks is a one time static operation, I mean if I
have imported IE's bookmarks, and if I add one in IE, I won't see it appear in
Mozilla unless I redo an importation.

=> here is what I usually tell people (on usenet for instance) : 
1/ go in IE, export the bookmarks to file bm.htm
2/ go in Mozilla, import the bookmarks from same file

I never heard anyone complain about the hardness of this way of doing things,
maybe it is enough for end-users, and maybe removing this "import from IE"
feature could be a good idea ?
What about those of us who never use IE and don't want to have to delete their
imported bookmarks each time we upgrade Mozilla versions?  At the very least,
the user should be asked at the time of install about importing bookmarks from
other programs -- it shouldn't be a default action.
*** Bug 182486 has been marked as a duplicate of this bug. ***
This is also a problem in 1.2.1
loss of data -> critical.
Severity: major → critical
*** Bug 184462 has been marked as a duplicate of this bug. ***
Keywords: dataloss
*** Bug 184651 has been marked as a duplicate of this bug. ***
*** Bug 185079 has been marked as a duplicate of this bug. ***
*** Bug 185133 has been marked as a duplicate of this bug. ***
Flags: blocking1.3b?
Flags: blocking1.3b? → blocking1.3b-
*** Bug 185511 has been marked as a duplicate of this bug. ***
*** Bug 186248 has been marked as a duplicate of this bug. ***
*** Bug 186572 has been marked as a duplicate of this bug. ***
*** Bug 186817 has been marked as a duplicate of this bug. ***
*** Bug 187339 has been marked as a duplicate of this bug. ***
I think that this is an important feature for windows users who may switch back
and forth between IE and Mozilla. <gasp.> Also, how does the inability to import
affect the actual C:\WINDOWS\Favorites directory. Can we narrow this down to
specific versions of IE? Or is this a Mozilla regression?
*** Bug 187647 has been marked as a duplicate of this bug. ***
*** Bug 188416 has been marked as a duplicate of this bug. ***
*** Bug 189831 has been marked as a duplicate of this bug. ***
Blocks: 190867
Attached patch patch v1.0 (obsolete) — Splinter Review
the regression has been introduced by rjc's checking preventing in same cases
to assert a resource that is not in the BookmarksRoot hierarchy.
IE import fails because it relies on CreateFolderInContainer that first creates
a folder (calling CreateFolder) and then make it a child of the container.
This patch do what Phoenix does, though I have no windows build so it would be
good to test it.
Ben is there a valid technical reason to prevent assertion on isolated
resource?
Attachment #112939 - Flags: superreview?(jaggernaut)
Attachment #112939 - Flags: review?(ben)
This looks like a pretty small change to fix a pretty big regression. If it gets
an sr in the next day or two it could make 1.3beta. 
Comment on attachment 112939 [details] [diff] [review]
patch v1.0

I'll have to spend more time on it.
Attachment #112939 - Attachment is obsolete: true
Attachment #112939 - Flags: superreview?(jaggernaut)
*** Bug 192164 has been marked as a duplicate of this bug. ***
This problem is also present in the Mac OS X build.  The problem described in
Bug 190867 is identical to the one in Bug 192164
OS: Windows 2000 → All
Hardware: PC → All
*** Bug 193385 has been marked as a duplicate of this bug. ***
*** Bug 195075 has been marked as a duplicate of this bug. ***
*** Bug 195282 has been marked as a duplicate of this bug. ***
Nav triage team: nsbeta1+/adt2
Assignee: ben → varga
Keywords: nsbeta1nsbeta1+
Whiteboard: [adt2]
Priority: -- → P3
Target Milestone: --- → mozilla1.4alpha
Blocks: 196756
*** Bug 190867 has been marked as a duplicate of this bug. ***
Will this make it before 1.4a? This is fairly high-profile for my branded projects.
*** Bug 116712 has been marked as a duplicate of this bug. ***
Flags: blocking1.4a?
Flags: blocking1.4a? → blocking1.4a-
*** Bug 198699 has been marked as a duplicate of this bug. ***
*** Bug 198734 has been marked as a duplicate of this bug. ***
The bookmarks branch has landed.
Fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
This issue has been fixed in the 2003-03-26-08 Win32 build but still occurs in
the Mach0 (2003-03-25-03) trunk build using a new profile. I will check in the
next Macho build to see if this has been fixed.
Blocks: 173383
*** Bug 200474 has been marked as a duplicate of this bug. ***
I delted ver 2003040105, then deleted the profiles, then the mozilla.org 
directory.  After reinstalling, it imported the favorites correctly
I just installed Mozilla 1.4a (Build: 2003040105) and it still does NOT import
my IE Favorites.   I'm running Windows XP, IE 6
If you have not also created a new profile, then I believe that is expected.
*** Bug 202184 has been marked as a duplicate of this bug. ***
This is fixed on the macho (2003-06-04-05) branch and (2003-06-04-08) trunk
builds. Need to check win32 build.
It work correctly.
Verified on win32 trunk (2003-06-03-08) and branch (2003-06-04-05) builds.
Status: RESOLVED → VERIFIED
*** Bug 210467 has been marked as a duplicate of this bug. ***
*** Bug 220234 has been marked as a duplicate of this bug. ***
In Firefox, it still reproduces.
bookmark of IE is not import when it starts in the state where there is no 
Profile.
By the manual, it can import normally in "File --> Import" of bookmanager.

Windows XP Pro SP1

Firefox 1.0PR
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040928 
Firefox/0.10
Product: Browser → Seamonkey
*** Bug 224539 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: