176767 - Menus at left edge of screen are shifted to the right slightly (Firefox File menu misaligned)

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Maximize Mozilla or Phoenix.
2. Open the File menu.

Result: The menu opens, but it's several pixels to the right of where it should
be.  This looks ugly.  There seems to be an invisible margin at the left edge of
the screen where Mozilla avoids putting menus.

You can also see this bug if you right-click at the left edge of the screen.
This bug has existed for a while, but it was recently made more visible by the
removal of toolbar grippies (bug 112534), which makes the bug also happen with
the menu bar.

Comment 1

[Sébastien Delahaye]

*** Bug 201703 has been marked as a duplicate of this bug. ***

Comment 2

[Sébastien Delahaye]

Jesse, now that the toolbar grippies are back in Moz, shouldn't this be turned
into a Phoenix-only bug?
(adding a MZo thread discussing this)

Comment 3

[Jesse Ruderman]

No, because it also happens with context menus in a maximized Mozilla window.

Comment 4

[Robert Morris]

Just adding my comments that, since Mozilla Thunderbird has switched to the new
toolkit, that it also happens in there. (Nothing unexpected, but so far only the
Mozilla suite and Mozilla Firebird are mentioned--and the summary itself
mentions only "Phoenix" [with a small "p"]--so I just thought I'd throw this in.)

Comment 5

[Robert Morris]

Changing summary to mention Firefox instead of Phoenix.

Comment 6

[lordmedikit]

This is very annoying, especially when making themes. Please, if possible change it.

Comment 7

[Chief Justice]

this looks very unprofessional... fix it pls!

Comment 8

[Chief Justice]

6 months later and still not fixed...
a clear ff 1.1 blocker! ;-)

Comment 9

[Chief Justice]

you gonna ship 1.1 with this bug?! shame on you!!!

Comment 10

[PikeUK]

*** Bug 296049 has been marked as a duplicate of this bug. ***

Comment 11

[Daniel C]

Could the Summary be changed from:

Menus at left edge of screen are shifted (Firefox File menu misaligned)

to

Menus at left edge of screen are shifted to the right slightly (Firefox File
menu misaligned)

so as to include the word 'right'.

Comment 12

[Dave Townsend [:mossop]]

WFM and as far as I remember always has.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050529
Firefox/1.0+ ID:2005052914

Comment 13

[Aaron Kaluszka]

Nope, still doesn't work.  Default theme.
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8b2) Gecko/20050531
Firefox/1.0+

Comment 14

[Martijn Wargers (dead)]

Well, removing this code makes it work for me:
   // inset the screen by 5px so that menus don't butt up against the side
  const PRInt32 kTrimMargin = 0;
  screenLeft += kTrimMargin;
  screenTop += kTrimMargin;
  screenRight -= kTrimMargin;
  screenBottom -= kTrimMargin;
  screenWidth -= 2 * kTrimMargin;
  screenHeight -= 2 * kTrimMargin;
It was checked in here:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/xul/base/src&command=DIFF_FRAMESET&file=nsMenuPopupFrame.cpp&rev1=1.80&rev2=1.81&root=/cvsroot

Comment 15

[Martijn Wargers (dead)]

Attachment: patch

Mike, can this code safely be removed, or does it still serve a purpose?

Comment 16

[Martijn Wargers (dead)]

There is a smallish issue with the patch: In WindowsXP you get a dropshadow on
the menu (or should get, but that's bug 282059). With this patch it the
dropshadow gets hidden behind the right edge, when a popup menu appears at the
right edge.

Comment 17

[Robert Morris]

(In reply to comment #16)
> There is a smallish issue with the patch: In WindowsXP you get a dropshadow on
> the menu (or should get, but that's bug 282059). With this patch it the
> dropshadow gets hidden behind the right edge, when a popup menu appears at the
> right edge.

Does this mean that the menu is so far against the right side of the screen that
you cannot see its shadow (because the menu's right edge is flush against the
right of the screen)? If so, I actually think that would be OK--it's what other
Windows programs seem to do if you can get one of their menus to open right
along the right side. (HINT: If you want to see this for yourself, do it with a
program that uses "normal" Windows menus like Notepad or most Windows
programs--or if you insist on doing it with IE or Windows Explorer, try it with
the Favorites menu* not something like Tools or Help, unless you move them off
the screen and access them with the keyboard. Otherwise they have a peculiar
habit of aligning to the left edge of the parent menu bar item instead of the
left, which no other program seems to do.)    *for some reason, this menu
behaves differently from all the others--both those to the left of it and to the
right of it, maybe because it has to custom-draw a lot of things; in any case,
it's actually the one menu that mimics the behavoir other applications seem to
exhibit

Unless, of course, this also means that Mozilla doesn't display the *bottom*
half of the shadow even when it has space to do so.

Comment 18

[Martijn Wargers (dead)]

Attachment: patch v.2

Yes, previous patch didn't give room for the winxp dropshadow at the right and
the bottom, so that wasn't any good. This patch does.
Ideally, there should be a patch that checks if the OS supported dropshadows
and positioned the dropshadow accordingly, but that's not something that I'm
able to do. I think this is good enough (at least for now).

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 185130 [details] [diff] [review]
patch v.2

please add a comment explaining what the magic number '3' means

Comment 20

[Martijn Wargers (dead)]

Attachment: Same patch, but now with comment

Comment 21

[Martijn Wargers (dead)]

Boris, Robert or someone else, could you check this in please?

Comment 22

[Chief Justice]

updated my DeerPark Alpha1 with the final patch... works and looks great! thx

Comment 23

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 24

[Martijn Wargers (dead)]

*** Bug 248205 has been marked as a duplicate of this bug. ***