Closed Bug 178880 Opened 22 years ago Closed 22 years ago

Bug Creation Date doesn't get displayed in long list

Categories

(Bugzilla :: Query/Bug List, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: mcsmurf, Assigned: mcsmurf)

References

Details

Attachments

(1 file, 5 obsolete files)

When you make a query and then click on the long list-Button, there is no Bug
Creation Date (in Bugzilla it is for example "Opened: 2002-10-20 02:42")
displayed (it should be above the <hr>-line and Comment 0 in the bug, on the
right side of the page).
-->myself, want to create my own patch, then you can review it :-)
Assignee: endico → mcsmurf
Attached patch Patch 1 (obsolete) — Splinter Review
This patch should fix it, can someone take a look at it?
Status: NEW → ASSIGNED
Attachment #105841 - Attachment is obsolete: true
Attached patch Patch 2 (obsolete) — Splinter Review
This should be the right patch now, can someone take a look at it?
Attachment #105852 - Flags: review?
Attachment #105852 - Flags: review? → review?(terry)
Sorry, but whoever signed me up to review this patch: I do not consider 
myself sufficiently up-to-date on the codebase, nor do I have time to be 
doing Bugzilla stuff.  I don't know the procedure for removing my name 
from that and assigning someone else (see, I *told* you I wasn't up-to-
date), but someone should do that.
Comment on attachment 105852 [details] [diff] [review]
Patch 2

moving request to "whoever's available"
Attachment #105852 - Flags: review?(terry) → review?
Attachment #105852 - Flags: review? → review?(endico)
Comment on attachment 105852 [details] [diff] [review]
Patch 2

>Index: mozilla/webtools/bugzilla/attachment.cgi
>-#!/usr/bonsaitools/bin/perl -wT
>+#!F:/perl/bin/perl.exe -wT

This is bad :)


>Index: mozilla/webtools/bugzilla/template/en/default/bug/show-multiple.html.tmpl

Why did you include the bug.creation_ts twice?	On my test installation (pretty
much using the strait-from-cvs params) this makes "Bug Creation Date" apear
twice in a row.

For future reference of anyone trying to apply this patch, you should "patch
-p3" and it does have CR's in it (although patch seems to deal with these just
fine)
Attachment #105852 - Flags: review?(endico) → review-
*eek*,hm, I'll do it again.
Attached patch Patch 3 (obsolete) — Splinter Review
This should fix it
Attachment #105852 - Attachment is obsolete: true
Attachment #107803 - Flags: review?(jake)
Comment on attachment 107803 [details] [diff] [review]
Patch 3

I know it's not your fault that we went and changed some things in recent CVS,
but this doesn't quite work with what's out there now.

>+    bugs.remaining_time,
>+	date_format(creation_ts,'%Y-%m-%d %H:%i')

In order to be compatible with formats from other databases (mainly Sybase in
this case), the format here should be '%Y.%m.%d %H:%i'.  Also, date_format
should be aligned with bugs.remaining_time.  It looks like you used <Tab> to do
your indentation.  That actually isn't allowed according the the Bugzilla
styleguide (Tabs are interpited differently by different text editors).   The
Bugzilla tests check to make sure that the code doesn't have any tabs in it,
but I don't know that those still run on win32.

>+        <b>Opened: [% bug.creation_ts %]</b>

This should be [% bug.creation_ts FILTER time %].  This filter will make sure
the time is in the correct format for display and append the timezone as
defined by the site.

These changes were made as part of bug 67077.
Attachment #107803 - Flags: review?(jake) → review-
Target Milestone: --- → Bugzilla 2.18
Hmpf, next time I'll have to update my tree more often.
Attached patch Patch 3b (obsolete) — Splinter Review
well, nothing to say :-/; this should fix it
Attachment #107803 - Attachment is obsolete: true
Attachment #107821 - Flags: review?(jake)
Attachment #107821 - Flags: review?(jake)
Attached patch Patch 3c (obsolete) — Splinter Review
Attachment #107821 - Attachment is obsolete: true
Attached patch Patch 3dSplinter Review
Attachment #107824 - Attachment is obsolete: true
Attachment #107825 - Flags: review?(jake)
Comment on attachment 107825 [details] [diff] [review]
Patch 3d

This is the one...
Attachment #107825 - Flags: review+
Flags: approval?
Attachment #107825 - Flags: review?(jake)
Flags: approval? → approval+
OS: Windows 2000 → All
Hardware: PC → All
Checking in long_list.cgi;
/cvsroot/mozilla/webtools/bugzilla/long_list.cgi,v  <--  long_list.cgi
new revision: 1.33; previous revision: 1.32
done
Checking in template/en/default/bug/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show-multiple.html.tmpl,v
 <--  show-multiple.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
*** Bug 122919 has been marked as a duplicate of this bug. ***
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: