179177 - keywords and dependencies tables aren't locked when creating bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

keywords and dependencies can be added to a new bug, but those tables aren't
locked beforehand, although this is necessary to prevent a server error if an
installation is using the shadow database.

the fielddefs table also has to be locked, as it's used by the dependency
insertion code.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

as it turns out, so does the bugs_activity table.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fix for problem

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 105669 [details] [diff] [review]
patch v1: fix for problem

down with the shadowdb!
down with table-level locks!

r=bbaetz x2

Comment 4

[Dave Miller [:justdave]]

a=justdave

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.72; previous revision: 1.71
done