179184 - regetlastlist returns all bugs

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Bradley Baetz (:bbaetz)]

regetlastlist changes $::buffer, but then the params object is created from $cgi.

Quick fix - change

my $params = new Bugzilla::CGI($cgi);

to use $::buffer instead

Better fix is to rearrange code a bit; pathc coming

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: better fix

This is a better fix, in that its ever so slightly more efficent. Rather than
joining the bug_ids again, and then parsing them, create a CGI object with a
prefilled hash.

Also moves $params creation down to when we know it won't be replaced.

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 105670 [details] [diff] [review]
better fix

>-# The params object to use for the actual query itsself
>+# Now we're going to be running, so ensure that the params object is set up

Please use full stops in comments :-) And also, explain why the new CGI object
is created with ||=.

Other than that, r=gerv.

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

# Now we're going to be running, so ensure that the params object is set up,
# using ||= so that we only do so if someone hasn't overridden this
# earlier, for example by setting up a named query search.

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 105670 [details] [diff] [review]
better fix

This is just me doing some tests, guys - and I've found a bug, bug 179236.

Gerv

Comment 5

[Dave Miller [:justdave]]

a=justdave

Comment 6

[Bradley Baetz (:bbaetz)]

Fixed.