179188 - New flag system doesn't tell you what the flag was set on in bugmail

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect, P1)

Description

[Dave Miller [:justdave]]

http://bugzilla.mozilla.org/show_bug.cgi?id=179177


[e-mail] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |first-review+, second-
                   |                            |review+


In the old system it said "Attachment #xxxx Status" for the attachment statuses.

Comment 1

[J. Paul Reed [:preed]]

Attachment: Take 1

This is admittedly hackish, but it should fix the problem as I observed it.

Oddly enough, the patch/obsolete flags did not show this behavior, so...

Comment 2

[J. Paul Reed [:preed]]

Ccing the usual suspects.

Justdave: was this just for attachment statuses, or is it a bigger problem that
I'm missing?

Aside: must lay off the coffee...

Comment 3

[Dave Miller [:justdave]]

just for attachment statuses.  But you can set flags for bugs now, too, right? 
Does this take that into account?

Bug Flag
Attachment #.... Flag

etc.

Comment 4

[J. Paul Reed [:preed]]

Well, *that's* a new feature (flags for bugs).

I haven't played around with that (nor heard any discussion on it), so I'll
venture a guess and say no.

I'll play with it and update the patch as necessary.

Comment 5

[Joel Peshkin]

Comment on attachment 105702 [details] [diff] [review]
Take 1


Ideally, this should provide a link to the bug, not just to the status, but
that could be a distinct enhancment.

r=joel

Comment 6

[Myk Melez [:myk] [@mykmelez]]

This should be:

+        $what =~ s/^Flag/Attachment #$attachid Flag/ if $attachid;

... as attachment statuses have been renamed flags.

Comment 7

[Jacob Steenhagen]

Attachment 105702 [details] [diff] re-introduces the now obsolete term of refering to the flags
as attachment status.  I've just been looking at this and came up w/a slightly
different patch which I'll attach in a minute.

Comment 8

[Jacob Steenhagen]

Attachment: Alternate patch

The idea behind this version is that the Show Status page displays an
attachment link any time there's an $attachid so the email should too.

Comment 9

[Jacob Steenhagen]

One of these days I'll learn to type cvs diff -u  :)

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 105705 [details] [diff] [review]
Alternate patch

this is the right fix
r=myk
a=myk

Comment 11

[Jacob Steenhagen]

-> me

Comment 12

[Jacob Steenhagen]

Checking in processmail;
/cvsroot/mozilla/webtools/bugzilla/processmail,v  <--  processmail
new revision: 1.93; previous revision: 1.92
done