Closed Bug 179203 Opened 22 years ago Closed 22 years ago

"Preset Queries" text does not appear in footer if last named query is not in footer

Categories

(Bugzilla :: User Interface, defect)

2.17
x86
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: bbaetz, Assigned: bbaetz)

References

Details

(Keywords: regression)

Attachments

(1 file)

IF you have some named queries which aren't in the footer, and one of those
ouwld belast in the list, then we get the 'are there any preset queries' logic wrong

We have:

    [% preset_queries = user.showmybugslink %]
    [% FOREACH q = user.queries %]
      [% preset_queries = 1 IF q.linkinfooter %]
    [% END %]

which parses as 

[% preset_queries = (1 IF q.linkinfooter) %]

so if !q.linkinfooter, preset_queries is set to false. Does this feel like a TT
bug to anyone else?

Fix is to add a SET; patch coming
Attached patch v1Splinter Review
trivial fix
No longer blocks: 179176
*** This bug has been marked as a duplicate of 175864 ***

*** This bug has been marked as a duplicate of 175864 ***
Blocks: 179176
Status: NEW → RESOLVED
Closed: 22 years ago
Keywords: regression
Resolution: --- → DUPLICATE
I like bbaetz patch better, though. :-) It's more obvious what's going on.
r=gerv on this patch.

Gerv
ok, we'll do it the other way around then....
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
*** Bug 175864 has been marked as a duplicate of this bug. ***
Comment on attachment 105676 [details] [diff] [review]
v1

r=gerv.

Gerv
Attachment #105676 - Flags: review+
a=justdave
Fixed
Status: REOPENED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: