Closed Bug 179205 Opened 22 years ago Closed 22 years ago

flag options incorrect

Categories

(Bugzilla :: Attachments & Requests, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: myk, Assigned: myk)

References

Details

Attachments

(1 file, 2 obsolete files)

Flag options don't match what their type configuration says they should be.  In
particular, active plussed flags look inactive and unrequestable flags show a "?".
Attached patch patch v1: fix for problems (obsolete) — Splinter Review
Attachment #105677 - Flags: review?
Comment on attachment 105677 [details] [diff] [review]
patch v1: fix for problems

r=gerv.

Gerv
a=justdave
Target Milestone: --- → Bugzilla 2.18
Attached patch patch v2: more comprehensive (obsolete) — Splinter Review
This patch takes care of one extra situation resulting in a mismatch and cleans
up formatting by preventing (<input ...>) from wrapping between the input field
and the parentheses.
Attachment #105677 - Attachment is obsolete: true
Attachment #105679 - Flags: review?
Comment on attachment 105679 [details] [diff] [review]
patch v2: more comprehensive

doesn't seem to want to let me okay the review. :-)  But that's what this is
supposed to fix, right? :)

r=justdave
This patch handles the situation where something has been made inactive and a
flag isn't set for it.	In that case it should appear, but it was appearing.
Attachment #105679 - Attachment is obsolete: true
Attachment #105681 - Flags: review?
Comment on attachment 105681 [details] [diff] [review]
patch v3: one more fix

r= justdave
Attachment #105679 - Flags: review?
Attachment #105677 - Flags: review?
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Attachment #105681 - Flags: review?
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: