179302 - 'anyexact' isn't an option for boolean charts

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Bradley Baetz (:bbaetz)]

The 'anyexact' query type doesn't appear to be accessible from boolean charts.
It works if you hack the html, and I can't see why we'd want to disallow it.

Thoughts?

Comment 1

[Bradley Baetz (:bbaetz)]

This is trivial if we decide to do this

Comment 2

[Gervase Markham [:gerv]]

No reason why we shouldn't do it, is there? However, history shows us it wasn't
in that list even before templatisation, so there might be a good reason:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/bugzilla/query.cgi&rev=1.92&root=/cvsroot
Line 876.

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

right; its not present in my 2.14 tree.

I'm guessing it was added later to buglist, and never added to the query stuff,
but that is just a guess

Dave/myk: do you know why? Its usable by tweaking the html, so it can't be for
any particuarlyl drastic reason.

Suggestions for a description to use?

Comment 4

[Bradley Baetz (:bbaetz)]

-> me, this would be useful.

Comment 5

[Bradley Baetz (:bbaetz)]

Attachment: trivial patch

This is really trivial; its just a ui change. The backend is well stested,
since thats what most of the non-boolean chart stuff uses internally

Comment 6

[Joel Peshkin]

Comment on attachment 105905 [details] [diff] [review]
trivial patch

r=joel

anyexact is not very forgiving....
"abc,grrgrr" matched the bug with "abc" and the one with "grrgrr". "abc grrgrr"
did not nor did "abc, grrgrr"

Comment 7

[Bradley Baetz (:bbaetz)]

We don't want spaces to separate, but I can see an argument for trimming. The
only problem with that is that anyexact is ued internally quite a bit, so if we
changed that then we may end up trimming on other (non-boolean) queries where we
didn't in the past. I don't know if thast an issue.

I think I'll leave it as is until/unless someone files a bug, then we can discuss.

FIXED

Comment 8

[Gervase Markham [:gerv]]

The fix would be pretty trivial; change the "[, ]" split in the search code to
/,?\s+/.

Gerv

Comment 9

[Bradley Baetz (:bbaetz)]

gerv: We definately don't want to split on spaces. Partly because I should be
able to search on 'the cat,the mat', but also because we use anyexact
internally, and things would then break. For example, searching on product=foo
or product=bar from the <select> becomes 'anyexact' 'foo,bar', which is then
resplit later

The same argument applies to trimming the result of the split.

/me wonders what happens if you search on a product with a , in teh name...

I suspect that our result code needs to be able to deal with arrayrefs, not just
values, but thats a separate (and much much larger) bug

Comment 10

[Gervase Markham [:gerv]]

> /me wonders what happens if you search on a product with a , in teh name...

Bad things. There's a bug open currently on bad things happening when you try
and search for a comma.

Gerv