181559 - MfcEmbed: Find in this page does not find Non-Ascii characters

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Teruko Kobayashi]

MfcEmbed: Find in this page does not find Non-Ascii characters.

Steps of reproduce
1. Launch MfcEmbed build
2. Go to Japanese web page, for example, http://www.yahoo.co.jp
3. Select menu Edit | Find This page
4. Type Japanese characters which you see in the page

Actual result:
The error "The text you entered was not found" message dialog will displayed.

Expected result:
The text you entered is found correctly.

Tested 11-22 branch and trunk Mfcembed build.

Comment 1

[Teruko Kobayashi]

Changed QA contact to myself.

Comment 2

[Teruko Kobayashi]

I forgot to mention that I used Win2k Japanese.

Comment 3

[Chris Nalls]

Marking Topembed+. Assigning to ftang - Frank please reassign as needed.

Comment 4

[Roy Yokoyama]

Attachment: call MultiByteToWideChar()

Data corruption occured by calling nsString::AssignWithConversion().

Note: mfcembed is not an unicode application. Though we can enter the 
      non-locale text, we won't be able to find string.  Only the text
      matching the system locale is valid. 
      (ie.  Korean in Japanese OS is not supported)

Comment 5

[Roy Yokoyama]

Attachment: fixing the indent

Comment 6

[Roy Yokoyama]

assign to myself and cc reviewers.

Comment 7

[Roy Yokoyama]

Comment on attachment 107968 [details] [diff] [review]
fixing the indent

can you review?

Comment 8

[Roy Yokoyama]

Comment on attachment 107968 [details] [diff] [review]
fixing the indent

chak: can you super review?
( not sure if you have
 the privilage.  If not, 
 then please let me know
 and recommend someone )

Comment 9

[Adam Lock]

It may be clearer to use the ATL/MFC macros for this conversion, e.g.

USES_CONVERSION;
finder->SetSearchString(T2W(dlg->GetFindString().GetBuffer(0)));

This should mean the code will still work even if mfcEmbed is built in Unicode mode.

Comment 10

[timeless]

Comment on attachment 107968 [details] [diff] [review]
fixing the indent

classical sr refers to people on http://www.mozilla.org/hacking/reviewers.html

Comment 11

[Roy Yokoyama]

Attachment: use USES_CONVERSION

Using MFC MBCS/Unicode Conversion Macros

Comment 12

[Roy Yokoyama]

Comment on attachment 108047 [details] [diff] [review]
use USES_CONVERSION

review for me again?

Comment 13

[Roy Yokoyama]

Comment on attachment 108047 [details] [diff] [review]
use USES_CONVERSION

kin: can you super review?

Comment 14

[kinmoz]

Comment on attachment 108047 [details] [diff] [review]
use USES_CONVERSION

sr=[e-mail]

Comment 15

[Roy Yokoyama]

checked into the trunk.

Comment 16

[Teruko Kobayashi]

I verified as fixed in 2002-12-5 Mfcembed trunk build.