182512 - Charts over time broken

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect, P3)

Description

[Joel Peshkin]

2 problems in 2.17.1

1) On product -All-, it gives an access denied error

2) On smaller charts, the chart comes up blank.


Checking for              GD (v1.20)   ok: found v1.38
Checking for     Chart::Base (v0.99)   ok: found v0.99
Checking for     XML::Parser (any)     ok: found v2.31
Checking for       GD::Graph (any)     ok: found v1.35
Checking for GD::Text::Align (any)     ok: found v1

Comment 1

[Gervase Markham [:gerv]]

WFM on b.m.o; you will need to give more information.

Gerv

Comment 2

[Joel Peshkin]

This is on tip.  
I still have not figured out why this is.  It looks like "-All-" needs to be
handled specially.

Comment 3

[Joel Peshkin]

Attachment: Patch for the obvious problem

Comment 4

[Joel Peshkin]

I'll fix the clear problem

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 107747 [details] [diff] [review]
Patch for the obvious problem

Looks fine to me. r=gerv. But I still need more details on "On smaller
charts..."

Gerv

Comment 6

[Joel Peshkin]

This change is a regression where the loss of the GroupExists() logic caused
-All- to be treated as a product for which the user has no permissions.

The second matter is something that seems not to effect all sites.  If I ask for
a chart for anything other than -All-, I get a blank chart.  The culprit for
that seems to be either that I don't have support for GIFs and the charting
package is trying to use them or that GD::Image is now required and not checked
by setup.  I get an error....
Can't locate object method "gif" via package "GD::Image" (perhaps you forgot to
load "GD::Image"?) at /usr/bonsaitools/lib/perl5/site_perl/5.6.1/Chart/Base.pm l
ine 167.            
in the webserver's error_log.

I tried loading GD::Image from CPAN, but it does not seem the be a distinct
installation.  Could this be yet another dependency on the version of GD?

Comment 7

[Joel Peshkin]

For the other problem, it seems that the GD upgrade that makes it possible to
use the new charting stuff breaks the old charting used for the charts over time.

This no longer works even on 2.16.1

Since the new charting stuff does work just fine on both these sites, I think I
will wait and see how Gerv's new charting over time works. That is what I really
need anyway.

Comment 8

[Gervase Markham [:gerv]]

Yes; GD 1.19 was the last one to support GIF; we now need 1.20 or above.
However, the charts over time should use PNG if they can't use GIF, so there is
a problem here if they aren't.

Gerv

Comment 9

[Joel Peshkin]

True, though I tried forcing it to "png" and it did not help.

Comment 10

[Joel Peshkin]

Checking in reports.cgi;
/cvsroot/mozilla/webtools/bugzilla/reports.cgi,v  <--  reports.cgi
new revision: 1.63; previous revision: 1.62
done                     

Comment 11

[Gervase Markham [:gerv]]

Well, they work on b.m.o., so they are obviously not broken for everyone.

Myk: what versions of GD and Chart::Base does b.m.o. have?

Gerv

Comment 12

[Myk Melez [:myk] [@mykmelez]]

GD 1.32, Chart::Base 0.99