184350 - About Popup Blocking dialog has a _working_ resizer in the status bar example

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[:deanis74]

See attachment.  The resizer beside "Document: Done" works.  I can resize the
window by dragging it.

Comment 1

[:deanis74]

Attachment: the aforementioned screenshot

Comment 2

[Tim Powell]

I'm glad to pay this price to see a working resizer in the ACTUAL statusbar.
It's about time.

Phoenix developers, I think I'd just call this an easter egg and move along. You
could put some extra text on the dialog's status bar that only shows up when you
use the resizer. :-)

By the way, shouldn't the text say simply "Done" instead of "Document: Done"? I
think Phoenix changed that on the actual status bar.

Comment 3

[:deanis74]

Tim: that's bug 184353, which I fixed last night

Comment 4

[David Tenser [:djst]]

I like that easter egg suggestion! :)

Also, the text should change to "Done".

Comment 5

[:deanis74]

David: see comment 3

Comment 6

[Blake Ross]

heh.

Comment 7

[Pham]

I don't think I see it anymore with the new Qute theme

Comment 8

[Karl Guertin]

This is still visible in WinXP with the default luna theme when the window is
not maximized. I like the easter egg idea. That would be cool.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030728 Mozilla
Firebird/0.6.1

Comment 9

[Pham]

I see it now with the resize bug fixed

Comment 10

[Mike Connor [:mconnor]]

-> taking

should be easy enough to fix

Comment 11

[Steffen Wilberg]

Copy chrome://browser/content/pageReportFirstTime.xul to the url bar to test this.

Comment 12

[Patrick Quaedackers]

*** Bug 233656 has been marked as a duplicate of this bug. ***

Comment 13

[Patrick Quaedackers]

Don't fix this... it's a nice easer egg indeed!
The "malfunction" is not anoying in any way!

Comment 14

[Mike Connor [:mconnor]]

the reality of this bug is that I don't think this matters, the dialog is only
shown once, who cares if it gets resized? :)

I should probably WONTFIX this :)

Comment 15

[PikeUK]

*** Bug 243422 has been marked as a duplicate of this bug. ***

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Don't WONTFIX it, but don't feel obliged to have it block anything ;-) 

Comment 17

[Brant Gurganus]

The problem isn't that it resizes.  The problem is that the resizer is in the
wrong place.

Comment 18

[Worcester12345]

(In reply to comment #17)
> The problem isn't that it resizes.  The problem is that the resizer is in the
> wrong place.

Well, it doesn't really NEED to resize at all. Don't know how much code it
takes, but any streamlining helps.

Comment 19

[Mike Connor [:mconnor]]

it doesn't take any code, actually, it'd probably be harder to undo it

although, I don't think this is even valid anymore, since I think the dialog is
dead.

Comment 20

[Worcester12345]

Perhaps the bug should be closed then?

Comment 21

[Steffen Wilberg]

The dialog isn't dead. It's displayed upon selecting "Don't show info message
when popups are blocked" from the context menu of the popup button on the statusbar.

Comment 22

[Steffen Wilberg]

Attachment: patch

This is inspired from the code for the main window:
http://lxr.mozilla.org/aviarybranch/source/toolkit/content/xul.css#331

I added it to browser.css because that is already referenced by
pageReportFirstTime.xul. I'm not sure about Pinstripe.

Comment 23

[Worcester12345]

This one should be bumped up to "normal" or at least "minor" priority, though
not a blocker.

Comment 24

[:deanis74]

(In reply to comment #23)
> This one should be bumped up to "normal" or at least "minor" priority, though
> not a blocker.

Definitely not.  In fact, I'm downgrading it back to trivial (I can do that, I
filed the bug).  It really is a cosmetic bug and nothing more.

Comment 25

[Asa Dotzler [:asa]]

Comment on attachment 154572 [details] [diff] [review]
patch

Please don't request approval until you've received necessary reviews. Thanks.

Comment 26

[Worcester12345]

Can this one come in before PR?

Comment 27

[Steffen Wilberg]

Finally!

Checking in mozilla/browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.14; previous revision: 1.13
done

Comment 28

[Dave Townsend [:mossop]]

*** Bug 305022 has been marked as a duplicate of this bug. ***