184805 - Close button in the tab bar has no tooltip

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Marc Boullet]

patch following

Comment 1

[Marc Boullet]

Attachment: patch

Not very happy with this patch, but it works.

Comment 2

[Neil Parks]

Perhaps related:  The "back" button performs two different functions, as
indicated by the left arrow and the down arrow.  But hovering over either arrow
displays the same tooltip:  "Go back one page".  

Comment 3

[Neil Parks]

Please withdraw my earlier comment.  I did not notice that the orig bug
specifically addresses the Tab bar.  The "back" button is not on the Tab bar.

Comment 4

[José Jeria]

Isn't this a dupe of bug 113879?

Comment 5

[David Tenser [:djst]]

No, bug 113879 is for Mozilla SeaMonkey. This one is for Mozilla Firebird.

Comment 6

[Simon Paquet [:sipaq]]

Taking QA Contact as designated owner of Firebird-Menus. Sorry for bugspam.

Comment 7

[Simon Paquet [:sipaq]]

Marc, this patch looks fine, but is rather old and so likely bitrotted. Can you
please check that and update it if necessary. Then I will ask Asa or Noririty to
check it in for you.

Comment 8

[Bernie Zimmermann]

Attachment: An up-to-date version of Marc's original patch.

Comment 9

[Bernie Zimmermann]

I've submitted a version of Marc's original patch that shouldn't be bitrotted.  
Also adding myself to CC.

Comment 10

[Simon Paquet [:sipaq]]

Over to Bernie. Your patch, your bug.

Comment 11

[Simon Paquet [:sipaq]]

Taking

Comment 12

[Simon Paquet [:sipaq]]

accepting

Comment 13

[Simon Paquet [:sipaq]]

Attachment: Patch without bitrot

de-bitrotted patch of Marc's original patch

Comment 14

[Simon Paquet [:sipaq]]

Comment on attachment 137626 [details] [diff] [review]
Patch without bitrot

Pierre, can you review and check this in please. This is a minor usability
improvement, which would be nice to have in 0.8

Comment 15

[Mike Connor [:mconnor]]

c'mon Simon, its not a real blocker, but it would be nice to have :)

Comment 16

[Simon Paquet [:sipaq]]

Comment on attachment 137626 [details] [diff] [review]
Patch without bitrot

This patch is not going to make it, since it would introduce a
browser-dependency into the toolkit. 
review- from pch via IRC

Comment 17

[Simon Paquet [:sipaq]]

Pierre said, that he wanted to take this bug.

Comment 18

[Tim Meader]

So, does this mean that if I can get the necessary code into the toolkit, THEN
we can use the patch that's already here?

It's a pretty visible polish issue that the Close Tab button doesn't present a
tooltip, while every other button in the entire browser does.

Comment 19

[Simon Paquet [:sipaq]]

Taking, I think I have an idea how to fix this.

Comment 20

[Simon Paquet [:sipaq]]

My idea, didn't work.
Back to default owner

Comment 21

[Hiro]

The specification of close Tab button has changed. 

WONTFIX ?

Comment 22

[Hiro]

In new close Tab button, the tool chip is displayed. 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060130 Firefox/1.6a1

Comment 23

[Worcester12345]

Can this one block Bugzilla Bug 345741 Improve "All Tabs" menu active/visible tab feedback?

Comment 24

[Phil Ringnalda (:philor)]

Mostly WFM, since close buttons in tabs now have tooltips; a tooltip for the remaining sort without, when you set browser.tabs.closeButtons to 3 to get the single button at the end of the tabstrip, is wontfix according to mconnor, since if you've had to use about:config to explicitly ask for that close button, you already know what it does (or, if you've used an extension that turns it on, they can add their own tooltip).