Closed Bug 187126 Opened 22 years ago Closed 22 years ago

XPI and Jar files can't be installed in Windows

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.4b

People

(Reporter: BWallmeier, Assigned: bugzilla)

References

(
URL
)

Details

Attachments

(1 file)

Unset MOZ_STATIC_COMPONENT_LIBS
548 bytes, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021229 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021229 Phoenix/0.5

I can not install add ons or themes with the Nightly built from 29.12.2002.
I have this problem on an other page, too:
http://texturizer.net/phoenix/themes.html

When I click in Install it, nothing happend.
Or on the second Page I can see the jar archiv in the browser window.

Reproducible: Always

Steps to Reproduce:
1.Go on http://texturizer.net/phoenix/themes.html
2.Click "Install"
3.Nothing happend

Actual Results:  
Nothing happend

Expected Results:  
Phoenix should install an add on or a theme.
*** Bug 187178 has been marked as a duplicate of this bug. ***
Confirming.
Some people in the Px Forums are having the bug:
http://www.mozillazine.org/forums/viewtopic.php?t=3564
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Add ons couldn't be installed → XPI and Jar can't be installed
Summary: XPI and Jar can't be installed → XPI and Jar files can't be installed
It's not the javascript that is faulty then?
Severity: major → normal
I don't know. 
*** Bug 187336 has been marked as a duplicate of this bug. ***
Confirm: Cannot install xpi files using builds 2002-12-29, -30, 31 and 2003-01-01. 

Mozilla build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b)
Gecko/20030101  installs xpi just fine.
I have downloaded Nightly Built from 1.1.2003 and this version can not install
xpi  or jar.
Hmm where did you find the version 1.3b? 
The nightly version that I have found is only:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20030101 Phoenix/0.5

He (Ed in comment #6) installed Mozilla 20030101, not Phoenix 20030101, which is
why it is 1.3b and not 1.3a (which is a good question in and of itself as to why
Phoenix isn't 1.3b)
oh I should read better :D
*** Bug 187357 has been marked as a duplicate of this bug. ***
Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.3a) Gecko/20030102 Phoenix/0.5

With any Phoenix nightly 12/29 or later, on Win ME, any attempt to install any
extension or theme produces an error such as this:

Error: InstallTrigger is not defined
Source File: http://texturizer.net/phoenix/extensions.html
Line: 42

Is this a windows only bug? I can't reproduce with Phoenix or Mozilla builds
from yesterday. Has anyone that is seeing this checked to see if Mozilla nightly
builds suffer the same problem?
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20030102 Phoenix/0.5

d/l and install today from yesterday's nightly (phoenix).  can't speak for
mozilla builds, only phoenix.

i did delete all profiles and installed from scratch and the problem was
immediately apparent -- to the point that i tracked down this bug and voted for
it :)

-- lee
Yes Asa, it is Windows-only. The same builds in Linux continue to install XPIs
and JARs without any problems.
Any chance this is related to Bug 186938 ?  A lot of code was removed with that
and it was during the 24 hour period between the 12/28 build and the 12/29 build.


Don't know if this explains anything, I'm posting for work so this won't be 100%
accurate, but McAfee detected xpiinstall.dll (or something similary named) as
being a Virii and promptly quarnteened it..   If I remember correctly it's
seeing the DLL as being Realtime-Spy and removing it..  I do not have heuristic
scanning enabled, so it thinks it's legit.  I have sent the dll to McAfee for
anaylsis and what not..
1) Why is this listed under XP? It's also a problem under 98SE.
2) Re: McAfee Virus detection. I'm not running McAfee. I use AVG and 
XPINSTAL.DLL in C:\phoenix\components has never been identified as suspicious or 
quarantineed.
Xpiinstall.dll has never been identified on my machine as a virus, either,
running Norton AntiVirus 2002 under XP Pro.

Has anyone discovered any "backdoor" routes to installing XPIs and JARs?  That
might help with the elimination process, as well.

As for why it's listed as a Windows XP bug, while it's not unique to XP, there
is no "All Windows" choice in the OS section, so one of the Windows operating
systems has to be chosen and XP was the OS it was first reported under.
"1) Why is this listed under XP? It's also a problem under 98SE."

Can't specify all Windows as an OS. But I can change the summary...

-->adding "Windows" to summary


I think this bug should really be major as well and the Target Milestone set to
0.6 as the next release should not be released with this bug still in existence.
Summary: XPI and Jar files can't be installed → XPI and Jar files can't be installed in Windows
> I think this bug should really be major as well and the Target Milestone set to
> 0.6 as the next release should not be released with this bug still in existence.

Couldn't agree more. Hope the developers don't mind.
Severity: normal → major
Target Milestone: --- → Phoenix0.6
I have also noticed that .XPI files are no longer associated with Phoenix.  When
you try to install one by clicking on it, Windows doesn't recognize it as
beloging to Phoenix; when you try to install one by downloading it, Phoenix
doesn't recognize the MIME type as internal to itself.
I imagine the bustage was from this checkin:

"12/28/2002 15:42
seawood%netscape.com
mozilla/ xpinstall/ src/ Makefile.in 1.65 2/1

Don't set EXPORT_LIBRARY for libs that aren't in the final link list for static
builds.
Fixing static build bustage."


That same file was modified a day earlier for bug 186241.
I'm not sure why that would affect Windows and not Linux though.
With the 20030107 build, I played about and got it working by reverting two files.

Replace components\compreg.dat and phoenix.exe with the ones from the 20021228
build and lo, .xpi files install again.

Hopefully there's a useful clue here.
*** Bug 188123 has been marked as a duplicate of this bug. ***
*** Bug 188379 has been marked as a duplicate of this bug. ***
Tired of running broken Phoenix so resinstalled build 20021119 this am.
Keeping data in C:\WINDOWS\APPLICATION DATA\PHOENIX
What to my suprise!
When I try to use the "get new themes" link from TOOLS | PREFERENCES | THEMES
AND EXTENSIONS a new blank white window opens and never loads.
Deleted data in C:\windows\application data\phoenix\*.* and reloaded 20021119,
"Get new themes" link still gives blank page which never loads.
Link from withing Phoenix Bookmarks works, loads page and I can change themes.
I don't quite understand why a total removal of application files with an old
build won't load the themes page..............
Hopefully this will provide some insight into this bug.
Also the inability to "right click" "save image as" works with the "new" (latest
build) data in  c:\windows\application data"
John, the 'save image as' is bug 188587.
I was able to get this working by a fairly tortured process: I started with today (20030115)'s nightly and a "known good" (in my case, 20021210) nightly. I copied chrome\comm.jar, components\xpinstal.dll, components\xpinstall.xpt and xpistub.dll from the known good nightly to today's, and with a text editor I copied all xpinstall references from the known good components\compreg.dat to the nightly (which was missing them all -- probably part of the problem). With all that done, I was then able to install mozgest from a local file (I haven't tried network XPIs  yet).
Of course, you'll want to put back the new nightly's comm.jar once you're done
doing the XPInstalls (otherwise, you get fun things like empty dialogs and unknown 
errors in the status bar, as is perfectly expectable for trying to run a 
mis-assembled program ;-).
I now get a complete shutdown/crash of the browser when attempting to install a
theme or an extension, and this is in Linux (20030117). Is this also happening
in the Windows builds now (a crash that is)?
I too get a complete crash upon attempting to install in Linux from 20030119 CVS.
Using win32 Mozilla 2003012005, and xpi installation works.
(http://adblock.mozdev.org/installation.html#)

Was it broken in Mozilla, too?  Or are you just pointing out that it's a Phoenix
only bug?
Yes, I was unable to install XPI on some of previous nightly Mozilla builds.

Reply to comment 31.

I started with Jan 1, and upgraded to Jan 20 while trying to diagnose.  There is
no CRASH in Windows, because there is nothing to crash.  The XPI file is not
recognized as anything executable.  Phoenix wants to know what program to use to
open an XPI file.  If I tell the OS to open an XPI file with Phoenix, then I end
up back with the what's this screen.


To Julo and Alan!
THIS IS AN PHOENIX ONLY BUG, not Mozilla.
I just built fresh with the check-in mentioned in comment 23 reverted, and the
install dialog does appear when I try to install the xpi from autoscroll.mozdev.org.

Seawood, are you sure this was the right change to fix static build bustage? 
That EXPORT_LIBRARY setting seems to have been there for a long time.
Looking a little more closely, though, my build isn't a static build.  I wonder
if that's enough to make the difference.
Dean, EXPORT_LIBRARY was added back when we first started working on adding
support for static builds.  It specifies which libs are supposed to be linked
directly into the application binary.  Since then, someone decided that
libxpinstall should always be dynamic so EXPORT_LIBRARY should not be set for
xpinstall.
Thanks Chris.  Given my comment 39 I may have been on a wild goose chase.  I'll
have to build a static build and see what happens.
Turns out that it was the previous checkin for the GRE that caused the problem.
 Since MOZ_STATIC_COMPONENT_LIBS was set, the module entry point for the
component was being translated and it wasn't being loaded in a static build.
um... I'm running the latest nightly for Redhat 8.0 and xpi and jar files do not
install...and as an added bonus they close the browser window.  same bug?
Comment on attachment 112196 [details] [diff] [review]
Unset MOZ_STATIC_COMPONENT_LIBS

The patch was checked in eariler tonight.
Marking Fixed.  Thanks Chris!!
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
*** Bug 190339 has been marked as a duplicate of this bug. ***
*** Bug 190454 has been marked as a duplicate of this bug. ***
Can we please have a nightly build for Windows containing this fix? Thanks.
Joseph Miller, please don't spam the bug report. This is NOT the place to ask
for new nightlies. If you don't have anything relevant to add to this already
fixed bug, then please comment in the forums instead.

(Sorry for spamming myself.)
Is this completely fixed or is there another similar bug or seperate bug?
Downloaded build 26 Jan 2003 and installed.
"Modern" theme still shows as present but doesn't install.
"Obit 3+1" shows as having installed but doesn't show in themes box. 
Now it appears I've lost cursor in Aqua-Jag. Go to TOOLS | PREFERENCES | THEMES
and it's back. Back to TOOLS | PREFERENCES | THEMES reset to "Classic" and it's
gone again. Back to TOOLS | PREFERENCES | THEMES and it's back.
No "modern" in C:\windows\......\chrome but it shows as available in "themes"
window.
Three morbit-1-2_20021031.xpi files (-1 and -2 probably from extra tries at
installing).
Where are these files supposed to go? in c:\.....default\9rykr6g1.slt or
c:\....\chrome? I've them in both.
Verified Fixed using build from 20030125.  I was able to install the autoscroll
extension without any problems.

John: It sounds like your issues are separate bugs.
Status: RESOLVED → VERIFIED
I have Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030205
Phoenix/0.5 and I make clean install, but when I try to install extensions they
open in vindow they got loded as garbage text instead off installing extension
mouse gesture from default location
Just installed Mouse Gestures 0.3.3 with Phoenix 2003-02-05 on W2K, works for me..
Hi it looks like only mouse gesture dont work from default page
http://texturizer.net/phoenix/extensions.html#Mouse%20Gestures
dont work properly I tried some other and it works
Unfortunetly this is only extension that I use and love
Can you install the older version of mouse gestures (0.3.3) from this page:
http://www.mozilla.org/projects/phoenix/extensions/
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: