188617 - Enhance embed_lite global history

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Conrad Carlen (not reading bugmail)]

The embed_lite global history implementation only stores the URL and the last
visted date for each entry. In order to support autocomplete, some other data is
needed. The object which represents an entry can easily be expanded and they can
still be stored in memory in an nsHashTable. The thing which needs to change is
the disk file format: instead of a simple format containing 2 fields per line,
something more expandable is needed. I'm thinking XML, using expat, which is
small & fast enough.

Comment 1

[Conrad Carlen (not reading bugmail)]

Setting to milestone that's not passed.

Comment 2

[Jordan Callicoat]

In nsEmbedGlobalHistory.cpp, the default number of new URLS untill history is
dumped to history.txt is 10:

static const PRInt32 kNewEntriesBetweenFlush = 10;

What is the reason for this? I am a K-Meleon user (which is still in development
of its global history implementation, and mostly works with the history.txt file
as of yet), and it is highly impractical to have such a set up. I have changed
the value to "1" url on my own buildIn nsEmbedGlobalHistory.cpp, the default
number of new URLS untill history is dumped to history.txt is 10:

static const PRInt32 kNewEntriesBetweenFlush = 10;

What is the reason for this? 

I am a K-Meleon user (which is still in the development of its global history
implementation, and mostly works with the history.txt file as of yet), and it is
highly impractical to have such a set up. I have changed the value to "1" URL on
my own build for us with K-Meleon.

Basically, I'm trying to figure out the rationale of waiting 10 URL before each
history dump. Thanks!

Comment 3

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.