Closed Bug 189076 Opened 22 years ago Closed 20 years ago

buttons in helper app dialog (ok/cancel in save as dialog box) are pushed downwards when OS-associated app is available (buttons cut off)

Categories

(Core Graveyard :: File Handling, defect, P3)

Product:
Core Graveyard
Component:
File Handling
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: bugzilla, Unassigned)

References

Details

(Whiteboard: [reflow-refactor])

Attachments

(2 files, 2 obsolete files)

screenshot from linux rh8.0, modern theme
12.31 KB, image/png
Details
real screenshot with hack
10.88 KB, image/png
Details 
found this on win2k and linux rh8.0 with 2003.01.13.08 comm trunk bits (both
themes). when there's an application provided for a filetype via an
OS-association, the OK and Cancel buttons are pushed downwards (sometimes
clipped) within the helper application dialog.

i think this might be a regression for the fix for bug 86640. it's minor so far,
since i can still access the buttons. however, if it's worse for others
(depending on screen resolutions), bump up as needed.

screenshot coming up.
helper application dialog, when there's an OS-associated application for a
mimetype.
This is basically the same problem as bug 112180, slightly exacerbated by the
checkin...

We could land a quick hack to fix it right now, if we want... let's wait a few
days on that; I may be able to fix the underlying reflow bug....
Um.  I see... you resolved that one....

Well, it's the same exact problem and the same dependencies apply...
Depends on: 188787
heh, yeah. wasn't sure if the underlying problem was the same (even though the
frontend appears different from bug 112180). your call though, if you want to
reopen 112180 and dup this one against it. or i can do that. whichever you
prefer. :)
taking this so it stays on my radar....
Assignee: law → bzbarsky
Attached image screenshot with hack (obsolete) — 

    
    

    
  


  

        Attachment #112248 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 112247 [details] [diff] [review]
wallpaper hack hack cough

Obviously not the ideal solution, but if it fixes the majority of these
occurrences it is better than what we have now.
r=pkw

        Attachment #112247 -
        Flags: review+

    
    

    
  
Comment on attachment 112247 [details] [diff] [review]
wallpaper hack hack cough

checked in.

        Attachment #112247 -
        Attachment is obsolete: true

    
    

    
  
Would it help to only show the dialog when all the info is known, and load that
info in the dialog's onload handler? Or is that just more wallpaper?

    
    

    
  
That's exactly what we're doing right now, no?  And yes, that would be wallpaper
-- the real bug is bug 188787
Priority: -- → P3
Target Milestone: --- → Future

    
    

    
  
*** Bug 202825 has been marked as a duplicate of this bug. ***
Summary: buttons in helper app dialog are pushed downwards when OS-associate app is available → buttons in helper app dialog (save as dialog box) are pushed downwards when OS-associate app is available (buttons cut off)
Depends on: 151930

    
    

    
  
adt: nsbeta1-
Keywords: nsbeta1 → nsbeta1-

    
    

    
  
On Mac OS X when saving a file, and three options are presented, the [OK] and
[CANCEL] are cutoff
Summary: buttons in helper app dialog (save as dialog box) are pushed downwards when OS-associate app is available (buttons cut off) → buttons in helper app dialog (save as dialog box) are pushed downwards when OS-associated app is available (buttons cut off)

    
    

    
  
*** Bug 225076 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 229786 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 231946 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 238953 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 239062 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243492 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 244052 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 244417 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 244484 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 245249 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 246322 has been marked as a duplicate of this bug. ***

    
    

    
  
Is there any reason why in the last two month the dupe count has increased so much?

    
    

    
  
(In reply to comment #27)
> Is there any reason why in the last two month the dupe count has increased so
much?

I upgraded from Mozilla 1.6 to Mozilla 1.7RC3 yesterday and have never see that
bug in v1.6 (possible regression?).

    
    

    
  
*** Bug 246389 has been marked as a duplicate of this bug. ***

    
    

    
  
Yes, this is a regression.  Sometime in the 1.0 timeframe.  The actual
underlying bug in XUL layout is not a regression, though -- it's just a design flaw.

There are no quick fixes here until we refactor layout and make
nsBoxToBlockAdaptor suck less....
Whiteboard: [reflow-refactor]
Summary: buttons in helper app dialog (save as dialog box) are pushed downwards when OS-associated app is available (buttons cut off) → buttons in helper app dialog (ok/cancel in save as dialog box) are pushed downwards when OS-associated app is available (buttons cut off)

    
    

    
  
*** Bug 246636 has been marked as a duplicate of this bug. ***

    
    

    
  
I would like to add some information from Bug 246636 here: The behaviour is
random; i. e. downloading from the exact same location (file type PDF), I get
the truncated prompt window with about 10% probability (see the screen shots in
Bug 246636).

New info: The problem is still in 1.7 release (WinXP).

    
    

    
  
*** Bug 248541 has been marked as a duplicate of this bug. ***

    
    

    
  
The problem is well understood... no real need for more info.
Assignee: bzbarsky → file-handling
QA Contact: chrispetersen → ian
Depends on: 255270

    
    

    
  
Fixed by the patch in bug 255270.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
*** Bug 257200 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 257680 has been marked as a duplicate of this bug. ***

    
    

    
  
I am still getting this bug in Mozilla 1.7.3 on Windows 2000. Buttons seem to be
clipped only the first time a file of unknown type is opened.

Both classic and modern themes are affected.

I upgraded from 1.5 (which was OK). I am also using enigmail.

    
    

    
  
*** Bug 185992 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 225294 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 179575 has been marked as a duplicate of this bug. ***

    
    

    
  
This problem still appears sometimes (Or a new regression?) on the trunk, see
Bug 280909.
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: