189563 - use of uninitialized value found by valgrind

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Valgrind was complaining about the use of an uninitialized value in a
conditional in jsinterp.c, and sure enough, _callHook in jsd_step.c appears to
not initialize hookresult. Patch follows.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: probable fix

I'm not completely sure what hookresult is supposed to mean, but this looks
right, and certainly can only improve the situation.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

->JSD

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 111893 [details] [diff] [review]
probable fix

Rob, wanna review this?

Comment 4

[Robert Ginda]

hookresult controls whether or not the call hook is called again on the way out
of the function in question.  I'd rather return JS_TRUE, just to be safe.

I'll check this in when the tree opens.

Comment 5

[Aleksey Nogin]

According to brad TBox, the warning is gone.