190411 - Bookmark Manager toolbar should have small icons

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, enhancement)

Description

[Ryuichi KUBUKI]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20030116 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20030116 Phoenix/0.5

Add small icons and notext option to Bookmark Manager toolbar,
like those of the navigation toolbar of browser.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[André Dahlqvist]

Yes, this is inconsistent UI. Confirming since I cannot find a dupe.

Comment 2

[Pham]

and javascript console?

Comment 3

[Erik]

*** Bug 206068 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 5

[Mike Connor [:mconnor]]

Changing this to normal implies this is a function that is broken, while the
reality is that it was never intended or implemented.

-> tweak summary to indicate what needs to be done
-> revert to enhancement
-> blocks bug 214529

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

The bookmark manager toolbar should use only small icons... not the huge ones it
has right now... text labels if any should be on the right. -ing. 

Comment 7

[Mathieu Pellerin]

I think it would be good to target this bug to firefox 1.0 (I wish it could be
for .9 but it's a little bit late)

The best way to implement this is, imo, to use the same configuration as the
main window. If one user select big icons with no text, let it be big icons and
no text accross all the dialogs (bookmark manager, javascript console). That's
the way I was expecting firefox to react when I first used it and saw that there
was no way to specify the size of the icons and the display of text under them ...

Comment 8

[Asa Dotzler [:asa]]

*** Bug 214529 has been marked as a duplicate of this bug. ***

Comment 9

[louis bennett]

having editable toolbars is a big mac thing. of course, if the toolbar doesn't
look to be editable (comment 6?), that would fix this, too. either way, i think
an important bug to fix for the mac version.

Comment 10

[Ryuichi KUBUKI]

Requesting blocking-aviary1.0. following Mac one. Is it too late?

Comment 11

[Mike Connor [:mconnor]]

already minused, don't renominate bugs that were already turned down.

its also "Way Too Late"

Comment 12

[chris hofmann]

seems like a lower priority task.

Comment 13

[Andreas Wuest]

This bug is <b>obsoleted</b> by bug #311309 (Bookmark Manager and JavaScript
Console toolbars should respect general toolbar settings) which deals with the
general toolbar settings problem of the Bookmark Manager and the JavaScript
Console, and not only with the "Use Small Icons" aspect of the Bookmark Manager.

Please continue discussion there.

Comment 14

[Ryuichi KUBUKI]

(In reply to comment #13)
> This bug is <b>obsoleted</b> by bug #311309 (Bookmark Manager and JavaScript
> Console toolbars should respect general toolbar settings) which deals with the
> general toolbar settings problem of the Bookmark Manager and the JavaScript
> Console, and not only with the "Use Small Icons" aspect of the Bookmark Manager.
> 
> Please continue discussion there.

Why? I prefer resolving problems one by one and this bug has 20 votes already.
If you want other aspects of BM/javascript console to "respect" (what's this?)
general toolbar settings, then please make separate bugs.

Comment 15

[Andreas Wuest]

(In reply to comment #14)

> (In reply to comment #13)
> > This bug is <b>obsoleted</b> by bug #311309 (Bookmark Manager and JavaScript
> > Console toolbars should respect general toolbar settings) which deals with the
> > general toolbar settings problem of the Bookmark Manager and the JavaScript
> > Console, and not only with the "Use Small Icons" aspect of the Bookmark Manager.
> > 
> > Please continue discussion there.
> 
> Why? I prefer resolving problems one by oneand this bug has 20 votes already.
> If you want other aspects of BM/javascript console to "respect" (what's this?)
> general toolbar settings, then please make separate bugs.

I DON'T want OTHER aspects to respect the settings of the toolbar customisation,
I want that the Bookmark Manager's and the JavaScript Console's toolbars respect
the "Use Small Icons" and icon+text, icon, text settings.

I shamelessly quote myself here from comment
https://bugzilla.mozilla.org/show_bug.cgi?id=311309#c4:

> Well, this [having only an overall setting set by the main browser toolbar
customisation dialog] would be the simplest solution to the problem (called "first
> solution" below). Of course it would be nice if we could set the "Use Small
> Icons" and wether to use icon+text, icon, or text properties independently on
> the toolbars in Bookmark Manager as well as the JavaScript Console (called
> "independent solution" below).
> 
> If someone has a patch for the independent solution, we should definitely
> consider it over the first solution, but if there exists only a fix deploying
> the first solution, I dare to say that this would still be better than the
> current situation!

Hope to have clarified this a bit.

Oh, and about the votes: common, the last substantial comment was from a year
ago, and there has not yet surfaced even the smallest patch at all.

Comment 16

[u88484]

This should be marked as INVALID or WONTFIX since places (which replaced bookmark manager) doesn't have icons.

Comment 17

[Andrei Boros]

Since this was first reported in 2003, i find it odd that still, at in 2006 at v1.5.0.3 firefox still does not have customize toolbar in the bookmarks manager window. 

TB has separate customize toolbar settings (and UI) for main window, message composition, addressbook. 

Comment 18

[Phil Ringnalda (:philor)]

*** Bug 343138 has been marked as a duplicate of this bug. ***

Comment 19

[Kevin Driver]

Places was dropped.  This is still an issue.

Comment 20

[Mike Connor [:mconnor]]

This should have been WONTFIXED when bug 256872

Comment 21

[Ryuichi KUBUKI]

(In reply to comment #20)
> This should have been WONTFIXED when bug 256872

I see no toolbar in the Places window even though I turn it on by view | toolbar. What's happening?

Comment 22

[Ryan Hayle]

I would argue that this should be re-opened as an RFE, at least.  I -don't- think the bookmarks toolbar should be customisable, I just think that it should follow the value that you specifically set when you customised the Firefox toolbar to begin with.  If that is set to no text labels, then the bookmarks window should not show them either.  This doesn't require any other theme or css changes, even if you don't include an extra set of small icons.

It should be a trivial change, shouldn't it?  The lack of consistency DOES look bad and unpolished.

FYI--bug 256872 is a dupe of this bug which has 3 more votes.

Comment 23

[Kevin Driver]

Mike, 

Not trying to spam, but originally Ben said that Bookmark Manager icons needed to be fixed.  See comment 6.  Why are you, then, wontfixing it?  

It's ugly like it is and inconsistent - we all know it.  

Are 20 (+3) votes not very many? 

Comment 24

[Mike Connor [:mconnor]]

a) that was two years ago
b) the toolbar icons were much much bigger than they are now.
c) with the current set of buttons, selective labels on right wouldn't work, since  the glyphs aren't so obvious as to be intuitive enough to allow easy usage
d) the UI is changing when we move to Places, so this bug applies only to Fx2

Comment 25

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change