193740 - timebomb code should be removed

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Bug 112071 turned on the timebomb by default again. Mozilla does not need the
timebomb and thus it should not be in the mozilla distribution.

If it's only netscape that needs this then it should be moved to the
netscape-tree, if others need it too then it should be moved to
extensions/transformiix and be off by default.

(not sure which component to put this in)

Comment 1

[Doug Turner (:dougt)]

build issue, or browser issue.  start with build.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

in comment 0 i of course mean "mozilla/extensions" nothing else

Comment 3

[jag (Peter Annema)]

I'd say build issue :-)

Comment 4

[hacker formerly known as [e-mail]]

Makefile changes are universal to all components so this should be owned by the
timebomb owners.  Ping leaf or dawn about copying code in the repository though.
-> xp apps

Comment 5

[jag (Peter Annema)]

Oh, fine, I guess I'll own it :-)

-> helpwanted

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

i'll offer to take this. I've pinged redhat and ibm and neither need the
timebomb code, so i'll simply remove it.

Comment 7

[Jon Granrose]

Netscape needs this code (or we did last time I checked).  If mozilla.org
decides it doesn't want the timebomb code in the mozilla tree, we need to move
it to the ns tree.

Comment 8

[Sebastian Späth]

There seem to be several timebomb implementations if I get it right. Please
check if the mozilla side couldn't be removed...

From bug 112071:
------- Additional Comment #12 From Blake Ross  2002-01-02 15:33 -------

Okay, so there was some miscommunication here.  I doublechecked that the
timebomb code in Mozilla was not the same as that used for Netscape builds (see
comment 37 in that bug)

Comment 9

[Josh Birnbaum]

*** Bug 212028 has been marked as a duplicate of this bug. ***

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

disables timebomb everywhere it occurs
in addition to this patch, xpfe/components/timebomb/* can be cvs removed

Comment 11

[[e-mail]]

Comment on attachment 131469 [details] [diff] [review]
patch

OK, so it looks good, and it builds, just don't forget to cvs remove region.dtd
as well.

Comment 12

[Simon Paquet [:sipaq]]

*** Bug 215468 has been marked as a duplicate of this bug. ***

Comment 13

[Simon Paquet [:sipaq]]

Comment on attachment 131469 [details] [diff] [review]
patch

Alec, can you please super-review? This should be pretty straightforward and is
only cleanup of unused function. Thanks.

Comment 14

[Alec Flett]

Comment on attachment 131469 [details] [diff] [review]
patch

sr=alecf
nice to see that killed :)

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

taking

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in.

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

this saved about 5kb of codesize, according to tinderboxes

Comment 18

[Steffen Wilberg]

There are a couple of files left to remove, mostly timebomb.dtd:
http://lxr.mozilla.org/mozilla/find?string=timebomb

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

l10n is not part of the mozilla build. I have no idea what it is used for.

Comment 20

[Steffen Wilberg]

l10n means localization: http://www.mozilla.org/projects/l10n/
The timebomb.dtd files contain the localization strings.
But I'm not sure about the l10n directory either.

Comment 21

[Simon Paquet [:sipaq]]

Biesi, when going through http://lxr.mozilla.org/mozilla/search?string=timebomb
I noticed that timebomb makefiles are still heavily called in
mozilla/allmakefiles.sh and mozilla/build/unix/modules.mk. I have (pretty huge)
cleanup-patches ready. Shall I attach them here?

Comment 22

[Christian :Biesinger (don't email me, ping me on IRC)]

>l10n means localization: 

I know.

> The timebomb.dtd files contain the localization strings.

As I said, the l10n directory is not used by mozilla

>I noticed that timebomb makefiles are still heavily called in
>mozilla/allmakefiles.sh and mozilla/build/unix/modules.mk.

Hm, so they are. I thought I had fixed allmakefiles.sh - apparently not enough.

No idea what modules.mk is used for.

> I have (pretty huge)
>cleanup-patches ready. Shall I attach them here?

if you want, but if you do so please reopen the bug

Comment 23

[Simon Paquet [:sipaq]]

Attachment: Remove all traces of timebomb from allmakefiles.sh and modules.mk

These two patches removes all traces of timebomb from allmakefiles.sh and
modules.mk
They are simple cleanup patches and both are pretty huge as textfiles, which is
why I'm supplying them in a zip-archive.

Comment 24

[Simon Paquet [:sipaq]]

Reopening, because there are still traces of timebomb code left in the tree.

Comment 25

[Simon Paquet [:sipaq]]

Attachment: Remove all traces of timebomb from allmakefiles.sh and modules.mk - version 1.0.1

Sorry, somehow the allmakefiles-patch was horked. This one should be better.

Comment 26

[Alec Flett]

please attach the patches as one big text patch - no zips please!

Comment 27

[Simon Paquet [:sipaq]]

Alec, I would supply the patches as textfiles, but they are too big for bugzilla
which allows only attachments up to 500K. The allmakefiles-patch is 900K big and
the modules.mk-patch has 1,2 MB.

Both files are pretty big in their original state so it's no wonder that the
patches get so huge, if you look at the number of occurences in
http://lxr.mozilla.org/mozilla/search?string=timebomb

I can put both patches on my webserver, if you want me to.

Comment 28

[Alec Flett]

good lord, I had no idea allmakefiles.sh was so convoluted these days...so
nevermind on that earlier request :) I was expecting a pretty small patch...

Comment 29

[Simon Paquet [:sipaq]]

Hi Alec,
The patch itself is pretty simple and straightforward for allmakefiles.sh
It simply removes all occurences (129) of the string 
" xpfe/components/timebomb/Makefile" (we need the leading space, so that we
don't have two spaces between both adjourning entries, after we remove the
timebomb-entry).

There are two additional occurences of timebomb in allmakefiles.sh:

MAKEFILES_timebombgen="xpfe/components/timebomb/tools/Makefile" in line 1659
timebombgen) add_makefiles "$MAKEFILES_timebombgen" ;; in line 1882

You could review this patch by simply comparing the size of the new and the old
allmakefiles.sh:

 xpfe/components/timebomb/Makefile":
129 x 34 bytes = 4386 bytes

MAKEFILES_timebombgen="xpfe/components/timebomb/tools/Makefile":
63 bytes + 4 bytes (two line-endings) = 67 bytes

timebombgen) add_makefiles "$MAKEFILES_timebombgen" ;;:
62 bytes + 2 bytes (one line-ending) = 64 bytes

4386 bytes + 67 bytes + 64 bytes = 4517 bytes

So the new file should be 4517 bytes smaller (at least it is on my windows machine).

Comment 30

[Simon Paquet [:sipaq]]

Just a followup-comment for my modules.mk-patch as well.

It simply removes all occurences (258) of the string " xpfe/components/timebomb"
(we need the leading space, so that we don't have two spaces between both
adjourning entries, after we remove the timebomb-entry).

There are three additional occurences of timebomb in modules.mk:

" timebombgen" in line 46 (without the quotation marks of course. We need the
leading space for the reasons given above)
"BM_DIRS_timebombgen	= xpfe/components/timebomb/tools  " in line 500
"BM_CVS_timebombgen	= xpfe/components/timebomb/tools  " in line 501

The trailing spaces are as they are in modules.mk. Again this is without the
quotation marks.

You could review this patch by simply comparing the size of the new and the old
allmakefiles.sh:

 xpfe/components/timebomb:
258 x 25 bytes = 6450 bytes

BM_DIRS_timebombgen	= xpfe/components/timebomb/tools  
BM_CVS_timebombgen	= xpfe/components/timebomb/tools  :
109 bytes + 6 bytes (three line-endings) = 115 bytes

6450 bytes + 115 bytes = 6565 bytes

So the new file should be 6565 bytes smaller (at least it is on my windows machine).

Comment 31

[Simon Paquet [:sipaq]]

Comment on attachment 132748 [details]
Remove all traces of timebomb from allmakefiles.sh and modules.mk - version 1.0.1

Brian, can you please review. The patches are zipped, because they were too
large for bugzilla. Comments 29 and 30 explain the patches and why they are so
big.

Comment 32

[Christian :Biesinger (don't email me, ping me on IRC)]

-> simon who is doing the work now

Comment 33

[Brian Ryner (not reading)]

Comment on attachment 132748 [details]
Remove all traces of timebomb from allmakefiles.sh and modules.mk - version 1.0.1

r=bryner

Comment 34

[Brian Ryner (not reading)]

checked in.

Comment 35

[Simon Paquet [:sipaq]]

verified fixed 2003-10-28.