Closed Bug 193965 Opened 21 years ago Closed 21 years ago

On product change, user can accidentally opt-out of required group restriction

Categories

(Bugzilla :: Creating/Changing Bugs, defect, P2)

2.17.3

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: bugreport, Assigned: bugreport)

References

Details

(Whiteboard: [fixed in 2.17.4])

Attachments

(1 file)

If a bug is in a product where a group restriction is optional AND the bug is
moved to a product where that same group restriction is mandatatory AND the user
choses "no" to "should the bug be placed in the new product's group"

THEN

The bug is removed from the previously-optional-now-mandatory group.  This will
be detected by sanitycheck and will be corrected the first time the bug is edited.

(This was seen on a 2.17.3 variant.... still needs to be confirmed on TIP)
Yeah, this exists on the tip as well.

Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.18
Attached patch The fixSplinter Review
OK, fix seems to work.	We will no longer remove old default groups if they are
mandatory for the new product.
Attachment #114858 - Flags: review?(justdave)
Comment on attachment 114858 [details] [diff] [review]
The fix

Looks pretty obvious, but I of course want a second opinion.
Attachment #114858 - Flags: review?(justdave)
Attachment #114858 - Flags: review?(bbaetz)
Attachment #114858 - Flags: review+
Comment on attachment 114858 [details] [diff] [review]
The fix

This looks fine. There are various conditionals beow which could do with some
commenting, though.
Attachment #114858 - Flags: review?(bbaetz)
WRT comment 4:  
I'd rather keep this as a "pure" one-liner and handle comment clean-up as a
seperate bug.
Flags: approval?
Blocks: 194034
Just FYI, I'm not ignoring this, but this is going to sit in "pending approval"
state until we're ready to roll on 2.17.4 because of the security status.
Blocks: 190911
Flags: approval? → approval+
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.182; previous revision: 1.181
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in 2.17.4]
Security Advisory has been posted, removing security group
Group: webtools-security
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: