195794 - missing access keys for Personal panel

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[sairuh (rarely reading bugmail)]

missing access keys for Personal panel. found using 2003.03.03.

1. select Tools - Form Manager - Edit Form Info
2. under Primary Contact Information, select the Personal category.
3. look at the labels for the droplists for Birthday and Anniversary.

results: there are access keys for "month", but not for day or year.

Comment 1

[Jessie Li]

I have noticed this before.
For day(dy) and year(yr), d,y,r is the suitable accesskeys.
If use _d_y, d_y_ for the two "day listbox", only one of two "year listbox" can
has accesskey which is r. So anyway there is one left which has no accesskey.

Another way is to replace the labels "dy" and "yr" with "day" and "year".

Aaronl, what do you think about this?

Comment 2

[Jessie Li]

The second way I suggested in comment 1 will affect the UI. If it is better like
now, I have to leave on "yr" no accesskey.

Comment 3

[piers]

I reckon just leave the last "yr" with no accesskey (i think full labels would 
use up too much space).

Comment 4

[Jessie Li]

Piers, I agree with you. Thanks for comments.

Comment 5

[Jessie Li]

Hi Piers,

Let's have a deep discussion about this problem.

1. For "dy", "d" is ok for "dy". "y" is a bad accesskey. I'd rather leave it no
accesskey. What do you think about this?

2. For "yr", "r" has been used for "Remove All Saved Date", I don't want to use
another accesskey for it since "R" seems to be consistent with others. So two
"yr" will not has accesskeys.

Do you agree with me? I hope to hear your comments. Thanks!

Comment 6

[piers]

Jessie, ok i think the best thing to do here is to not have any accesskey for mo,
dy or dr -- instead just assign an accesskey to "Birthday" and "Aniversery" and 
set the control to be the relevent "mo" textbox in each case. It's then easy for
the user to tab through the boxes (as with "Social Security Number".

Comment 7

[Jessie Li]

This case has a little difference with "Social Security Number". But what you
suggested is the better solution. Thanks!

Comment 8

[Jessie Li]

Attachment: patch

Comment 9

[piers]

Comment on attachment 116747 [details] [diff] [review]
patch

Looks good to me.

-> Dean for review.

Comment 10

[Jessie Li]

Dean, please help me to review this bug, it is very simple. Thanks!

Comment 11

[Kyle Yuan]

Comment on attachment 116747 [details] [diff] [review]
patch

r=kyle

Comment 12

[:deanis74]

Sorry about that, I completely missed this one!

Comment 13

[Jessie Li]

Jag, please help me to superreview this bug, it is very simple.

Comment 14

[Jessie Li]

Comment on attachment 116747 [details] [diff] [review]
patch

jst, could you help me super review this bug, it is very simple.

Comment 15

[Johnny Stenback (:jst)]

Comment on attachment 116747 [details] [diff] [review]
patch

sr=jst

Comment 16

[Bolian Yin]

checked in Trunk.