Closed Bug 201822 Opened 21 years ago Closed 21 years ago

Crash when using backspace key to go back - Trunk [@ nsDocShell::QueryInterface] [@ nsDocShell::AddRef]

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jason.barnabe, Assigned: bryner)

References

Details

(Keywords: crash, testcase, topcrash+)

Crash Data

Attachments

(3 files)

stack from talkback incident
7.33 KB, text/plain
Details
fix
714 bytes, patch
pavlov
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review
Fix back and forward reversal
829 bytes, patch
jag+mozilla
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030412
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030412

Pressing backspace to return to the previous document crashes Mozilla. This is a
new bug in 2003041208.

Reproducible: Always

Steps to Reproduce:
Comfirmed with 2003041208-trunk/Win-Me.
can you post Talkback ID for this crash "mozilla/bin/components/talkback.exe" ?
Keywords: crash, stackwanted
Talkback ID TB19109852M
It happens on my environment, too.
(2003041204,trunk,zip,w/o talkback),w2k

confirming based on OS/2 bug as well.
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 201838 has been marked as a duplicate of this bug. ***
I've got a fix.  It's a regression from sfraser's checkin for bug 201560.
Assignee: aaronl → bryner
Attached patch fix — — Splinter Review 
infinite recursion is bad.
Attachment #120420 - Flags: review+
Attachment #120420 - Flags: superreview?(sfraser)
Keywords: stackwanted
Comment on attachment 120420 [details] [diff] [review]
fix

D'oh! Thanks bryner. Shouldn't this be a smoketest blocker?
Attachment #120420 - Flags: superreview?(sfraser) → superreview+
Thanks for fixing this, bryner. JJ let me check it in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
*** Bug 201942 has been marked as a duplicate of this bug. ***
*** Bug 202017 has been marked as a duplicate of this bug. ***
Adding topcrash info for future reference.
Keywords: testcase, topcrash+
Summary: Crash when using backspace key to go back → Crash when using backspace key to go back - Trunk [@ nsDocShell::QueryInterface] [@ nsDocShell::AddRef]
*** Bug 202027 has been marked as a duplicate of this bug. ***
I'm not sure that this issue is really fixed. I just downloaded build 2003041412
and pressing BACKSPACE now does nothing. Sure the browser no longer crashes, but
now the backspace functionality is broken.
Still crashing for me with 2003041416. TB19158809M
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It's also crashing for me too. Browser: Build 2003041416 on Windows 2000
Professional (5.0.2195 Service Pack 3).

Talkback Crash Reports:
TB19159284Z
TB19159259G
That build must not have gotten this checkin somehow.  The stack signature is
the same which isn't really possible given the checkin.  I'm fairly confident
that tomorrow's AM build won't crash.
No crash for me now, but the backspace-functionality is broken. If I press the
backspace-button, nothing happens for me.

User-Agent is Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.4b)
Gecko/20030415
Well, I've just found out, that the backspace is now working the other way
around. Instead of going back, it goes forward, when I'm pressing the
backspace-button.
With 2003041508-trunk/Win-Me, crash when Backspace key problem has been resolved.
However, shortcut on Backspace seems to be miss-assigned, Backspace=Forward,
Shift-Backspace=Back.
Should we open another bug? 

WADA, please read comment #21 and comment #22
I misunderstood "Fix back and forward reversal" of comment #22 was already
checked in.
Sorry for my hasty conclusion and SPAM.
Comment on attachment 120588 [details] [diff] [review]
Fix back and forward reversal

r=/sr=jag
Attachment #120588 - Flags: superreview+
Attachment #120588 - Flags: review+
Well, WFM now with 2003041604 WinXP. Thanks.
resolving
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
vrfy'd fixed with 2003.04.16.09 comm build on win2k. Backspace goes back,
Shift+Backspace goes fwd a page.
Status: RESOLVED → VERIFIED
Crash Signature: [@ nsDocShell::QueryInterface] [@ nsDocShell::AddRef]
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: