205138 - "New Folder" button in "File Bookmark" dialog does nothing

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Doug Hockin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507

The New Folders button in the File Bookmark dialog doesn't produce the
new folder dialog. Nothing at all happens.


Reproducible: Always

Steps to Reproduce:
1. Bookmarks->File Bookmark
2. Click on New Folder button
3.

Actual Results:  
Nothing (button showed it was pressed, but nothing else happened).

Expected Results:  
Opened the New Folder dialog to get the name of the new folder.

Comment 1

[Hermann Schwab]

One step missing: select the folder where you want to create a new folder.

1. Bookmarks->File Bookmark
2. select a folder by clicking on it.
3. Click on New Folder button, the property window comes up, where you can
rename the just created folder.

WFM Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4b) Gecko/20030509

Comment 2

[Dirk Munk]

I had the same problem, and was going to submit a bug when I read this bug and
the last comment.

In my view there still is a small bug, and that is the absence of a popup window
with an error. Another possiblity is that the <new folder> button is greyed out
if no folder is selected.

Mozilla/5.0 (X11; U; OpenVMS AlphaServer_DS10_466_MHz; en-US; rv:1.4b)
Gecko/20030506

Comment 3

[Hermann Schwab]

Imho it would be no better, if you enter the page and the ok button is greyed out.
A better solution would be an automatic selection of last used folder, or first
folder, or a marked folder. Please reduce severity, the functionality is there,
but the usability is reduced for newbies.

Comment 4

[Doug Hockin]

Well, I'm at home where I don't have the 1.4b version, so I can't try it...

But it behaves differently that it used to if there is no default folder
selected to create the new one in.  Up until this version, it had
a default -- why has the behaviour changed, it worked just fine
the old way and now it's broken -- in my strong opinion.

I'm no newbie, and there was nothing clear about how it now behaves.
My report says what I thought was going on.

Where'd the default selection go?

Comment 5

[Chris Petersen]

Confirming issue. UI is confusing when no folder selection is made.

Comment 6

[José Jeria]

This is a very visible regression. 
Pressing the new folder button does nothing and give you a js-error:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXULTreeBuilder.getResourceAtIndex]" 
nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://communicator/content/bookmarks/addBookmark.js :: createNewFolder ::
line 293"  data: no]

Comment 7

[Daniel Küstner]

Can reproduce this with Linux, but not with NT4.0. Can see this everywhere
(i.e., in the context menu of the bookmarks sidebar tab, in the context menu,
the File -> New Folder menu entry and the New Folder button of bookmark manager
and with New Folder Button of Add Bookmark dialog.

Suggesting setting of OS to all, severity to critical and summary to "New Folder
dialog does not appear."

Comment 8

[José Jeria]

I only see this on the File Bookmark. Maybe is worse on Linux.

Comment 9

[Daniel Küstner]

Can see this still whith 1.4RC1 on Linux and NT4.

Comment 10

[rr_mozilla]

Still a problem on Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4) Gecko/20030529
RC1 when clicking Add under Bookmarks from sidebar Win95.

Comment 11

[José Jeria]

*** Bug 213235 has been marked as a duplicate of this bug. ***

Comment 12

[Asa Dotzler [:asa]]

mozilla1.4 shipped. unsetting blocking1.4 request.

Comment 13

[Hermann Schwab]

*** Bug 216805 has been marked as a duplicate of this bug. ***

Comment 14

[Jessica Blanco]

Attachment: modified addBookmark.js to always select a folder in the tree

For the "New Folder..." button to work, a folder must be selected. Right now
the code only selects a folder when trying to Move a bookmark in the Bookmark
Manager. I modified addBookmark.js to always select a folder unless the tree of
folders will not be displayed in the dialog (for the "newBookmark" case). This
will allow the "New Folder..." button to work when the File Bookmark dialog is
initially brought up.

Comment 15

[Mike Kaply [:mkaply]]

Comment on attachment 131254 [details] [diff] [review]
modified addBookmark.js to always select a folder in the tree

r=mkaply

Should there be a firebird version of this patch?

Or are things totally different there?

Comment 16

[José Jeria]

Firebirds "Add Bookmarks" dialog doesnt have this button available.

Comment 17

[rr_mozilla]

still not working in 1.5b

Comment 18

[Joe Infla]

*** Bug 220308 has been marked as a duplicate of this bug. ***

Comment 19

[Sam Katz]

should firebird have this button avaliable. is there an rfe for that?

Comment 20

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 21

[Jon Henry]

Looks to me like bug 181033 is the relevant Firebird RFE.