206692 - Land minor toolkit changes for thunderbird

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Scott MacGregor]

I need this patch in order to get thunderbird running with mozilla/toolkit.

Patch coming up.

Comment 1

[Scott MacGregor]

Attachment: patch

Comment 2

[Simon Paquet [:sipaq]]

Since this is mostly about changing makefiles, I think you should contact bryner.

Comment 3

[Scott MacGregor]

Attachment: updated patch to fix autocomplete in thunderbird

Thunderbird currently doesn't use the new toolkit's autocomplete. So I added an
ifdef MOZ_THUNDERBIRD to xul.css to bind autocomplete to the old autocomplete
binding.

Comment 4

[Scott MacGregor]

Everything in this patch has been checked in except for the following change to
allmakefiles.sh. Firebird seems to build console and components just fine
without this patch. But I'm not sure I see how the Makefile's get generated for
these two directories in firebird without my change. Holding off to make sure I
really need this...

Index: allmakefiles.sh
===================================================================
RCS file: /cvsroot/mozilla/allmakefiles.sh,v
retrieving revision 1.419
diff -u -w -r1.419 allmakefiles.sh
--- allmakefiles.sh     3 Jun 2003 23:15:41 -0000       1.419
+++ allmakefiles.sh     9 Jun 2003 04:33:10 -0000
@@ -867,6 +867,8 @@
 toolkit/components/satchel/Makefile
 toolkit/components/satchel/public/Makefile
 toolkit/components/satchel/src/Makefile
+toolkit/components/Makefile
+toolkit/components/console/Makefile
 toolkit/content/mac/Makefile
 toolkit/skin/mac/Makefile

Comment 5

[Calum Mackay]

I've just built Thunderbird from the trunk, without the patch in comment 4, so
perhaps it's not needed.

Everything seems to be working perfectly (nice to have an addressbook button now
too), including toolbar customisation, which wasn't before.

Comment 6

[Olivier Cahagne]

should this be marked Fixed ?

Comment 7

[Phil Ringnalda (:philor)]

The remaining bits were fixed by dbaron in bug 212509. Three years ago. Die, ghost bug, die!