Closed
Bug 207085
Opened 21 years ago
Closed 21 years ago
Updating a stored query shouldn't return the same message as creating one
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
2.15 KB,
patch
|
kiko
:
review-
|
Details | Diff | Splinter Review |
Attachment #124184 -
Flags: review?(kiko)
Comment 2•21 years ago
|
||
Comment on attachment 124184 [details] [diff] [review] add response > foreach my $query (@{$vars->{'user'}{'queries'}}) { >- if ($query->{'name'} eq $name && $query->{'linkinfooter'} == 1) { >+ if ($query->{'name'} eq $name) { >+ $vars->{'message'} = "buglist_updated_named_query"; >+ if ($query->{'linkinfooter'} == 1) { > $new_in_footer = 0; > } > } You missed a close-bracket there and the indent is wrong. I'd also suggest adding a break to that if clause as a micro-optim-correctness thing. r=kiko with those changes, this is nice.
Attachment #124184 -
Flags: review?(kiko) → review-
you mean last :) oh well. fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 4•21 years ago
|
||
Next time please get approval for your bug *before* you check it in. Thanks.
Flags: approval+
Target Milestone: --- → Bugzilla 2.18
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•