208583 - Remove PerformSubsts from templates

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Bradley Baetz (:bbaetz)]

PerformSubsts will vanish entirely once mail is templatised, but in th  meantime
it should be taken out of the templates. This prevents mod_perl, since its
currently in teh global namespace, and its less work to just remove the single
usage than to move the deprecated function.

Also removes pushing SyncShadowDB to the templates now that that function no
longer exists.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: Patch

Err, SyncPendingShadowChanges, rather. 

I removed the filereceptions entry for the line I'm removing. The new one
doesn't need an entry, since it falls into the 'Param is ok' case.

I also don't think that this is removing any functionality; I can't see much
use for any of the other params (which are the only other substs permitted) in
the my bugs template.

Comment 2

[Bradley Baetz (:bbaetz)]

Comment on attachment 125123 [details] [diff] [review]
Patch

nice, simple, etc

Comment 3

[Bradley Baetz (:bbaetz)]

Fixed.