208808 - {Find in this page} is broken

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Tom Sommer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030609 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030609 Mozilla Firebird/0.6

Using CTRL + F and typing in a query does not highlight the results in webpages
or in view source. It does not display a notice about "no results" either

Reproducible: Always

Steps to Reproduce:
1. Search for something you know exists on a webpage

1. Search for something in "view source" you know exist 

Actual Results:  
Nothing

Expected Results:  
The search-results should be selected/highlighted.
If no results is returned, this information should also be displayed.

Comment 1

[Erik]

Confirmed using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b)
Gecko/20030609 Mozilla Firebird/0.6, Mozilla Seamonkey works fine.

Confirming since I didn't find a possible dupe, will check for possible
regression time frames - summary should get tweaked a little bit.

Comment 2

[Erik]

2003-06-09 seems to be the first build showing this error. perhaps the changes
made to finddialog.js cause the problem:

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/toolkit/content/finddialog.js

Possible workaround is to replace toolkit.jar by the version taken from the
2003-06-08 build.

Comment 3

[Erik]

After creating a new toolkit.jar with the previous version of finddialog.js the
dialog {Find in this page} works again. => cc'ing Scott so he can have a look on it.

Comment 4

[Scott MacGregor]

Hmm thanks guys. Taking. 

Comment 5

[Scott MacGregor]

Do you get any JS errors in the JS console after attempting to do a find?

Comment 6

[Erik]

Scott, IIRC there was NO error in the JS script console. Currently I'm on a
different machine with an older build of Mozilla Firebird installed so I cannot
double-check, but I think I cleared the JS console and give it a second try just
to make sure I catch the error in case there is one present.

Comment 7

[Scott MacGregor]

I backed out my change until I can figure out why this doesn't work in firebird.

Comment 8

[Tom Sommer]

There are no errors in the JS console

Comment 9

[Max Gordon]

I don't know if this helps but this bug appeared for me soon after that I
enabled "typeaheadfind" which works fine except that I can't find anything but
the first element. This might very well be a coincidence but who knows :-)

Comment 10

[Erik]

Max, don't know if I get you correctly: on your box "enabling typeaheadfind"
causes the error with the {Find in this page} dialog? And when disabled the
{Find...}-dialog works ok?

Well I just disabled typeaheadfind via about:config but the problem is still
there using latest nightly Gecko/20030610, since I suppose the changes made by
Scott didn't made it into the latest nightly. 

And also if enabled typeaheadfind works just fine, e.g. finding many matches
does work without any problems - so currently I don't see any relations, in fact
I don't even see the problem with the typeahead :)

Comment 11

[Simon Paquet [:sipaq]]

*** Bug 209125 has been marked as a duplicate of this bug. ***

Comment 12

[james davis]

No workie in win2k 1.5a mozilla trunk 061908 either...

Comment 13

[Tom Sommer]

Actually it does work in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
rv:1.4b) Gecko/20030618 Mozilla Firebird/0.6 (Notice how I just supplied the UA?)

But that is expected since the patch was backed out. Don't know if that would
make this bug FIXED?

Comment 14

[james davis]

Let me be more specific, it doesn't work under Win2k using the nightly trunk
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/2003061908
No matter what you search for, you get the "alert: the text you entered
was not found" dialog. Should this(a) bug be opened/changed for the "browser"
product rather than just for phoenix?
I'm assuming that whatever changed affected the nightlies too.

Comment 15

[james davis]

...bbbuttt this mornings build worked OK.  062004
WFM (mark as fixed and reopen a new bug on the finddialog.js thing?)

Comment 16

[Tom Sommer]

This bug and problem was specific to Firebird.

This bug was fixed, by backing out the changes that caused the bug (comment #5).

As stated in comment #14 there was some problems with the search function in
20030619, not related to this bug... but these problems has been fixed in
20030620 (comment #15).

Marking fixed.

Comment 17

[noririty]

v.