209878 - [trunk] Character coding menu corruption

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Simon Montagu :smontagu]

Steps to reproduce: Click View | Character Coding | More
Expected results: after the area submenus, see UTF-8, UTF-7 and User Defined
Actual results: see a huge list of encodings.

Comment 1

[Alec Flett]

really? I thought you were supposed to see the big list? I thought I had gotten
it right some time back. I understand nsCharsetMenu a lot better now though, so
ping me if you need any help.

where are all those encodings supposed to appear then?

Comment 2

[Simon Montagu :smontagu]

I don't see the big list in 2003060608, which is the last nightly I could find
before the checkin from bug 206379.

I found something which looks wrong at
http://lxr.mozilla.org/mozilla/source/xpfe/components/intl/nsCharsetMenu.cpp#1050

    nsCStringArray othersEncoderList;
    CloneCStringArray(mDecoderList, othersDecoderList); 
//                                        ^^ shouldn't this be othersEncoderList?

    res = InitMoreMenu(othersEncoderList, kNC_EncodersRoot, ".notForOutgoing");
                

but changing it doesn't fix the bug.

Comment 3

[Simon Montagu :smontagu]

Attachment: Patch

I left in the change I suggested in the last comment, but the real fix is the
second chunk, changing IndexOf() to IndexOfIgnoreCase().

Comment 4

[Alec Flett]

Comment on attachment 126060 [details] [diff] [review]
Patch

r/sr=alecf

Comment 5

[Simon Montagu :smontagu]

Fix checked in.

Comment 6

[Jungshik Shin]

Simon, thanks for fixing 'decoder->encoder' typo. I remember spotting it while
reviewing Alec's patch for bug 206379, but apparently I forgot to mention it in
my comment to that bug. 

Comment 7

[Yuying Long]

Verified fixed in 06-23 trunk build.