210036 - tmTransactionService doesn't init mObservers

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[timeless]

xpcshell:
const C=Components.classes,I=Components.interfaces;
for (a in C) try {C[a].createInstance(I.nsIInputStream); print(a)}catch(e){}

PL_HashTableDestroy(PLHashTable * 0xcdcdcdcd) line 159 + 3 bytes
tmTransactionService::~tmTransactionService() line 82 + 12 bytes
tmTransactionService::`scalar deleting destructor'(unsigned int 1) + 15 bytes
tmTransactionService::Release(tmTransactionService * const 0x02095150) line 106
+ 106 bytes
tmTransactionServiceConstructor(nsISupports * 0x00000000, const nsID & {...},
void * * 0x0012e794) line 49 + 151 bytes
nsGenericFactory::CreateInstance(nsGenericFactory * const 0x020951d0,
nsISupports * 0x00000000, const nsID & {...}, void * * 0x0012e794) line 86 + 21
bytes

Comment 1

[timeless]

MSVCRTD! memset + 65 bytes
tmVector::~tmVector() line 48
tmTransactionService::~tmTransactionService() line 104 + 33 bytes
tmTransactionService::`scalar deleting destructor'(unsigned int 1) + 15 bytes
tmTransactionService::Release(tmTransactionService * const 0x020a53a0) line 111
+ 106 bytes
tmTransactionServiceConstructor(nsISupports * 0x00000000, const nsID & {...},
void * * 0x0012e794) line 49 + 151 bytes

This is fun:
>   Clear();
>   if (mElements)
>     free((void*)mElements);
> tmVector::Clear(){
>   memset(mElements, 0, mCapacity);

Comment 2

[timeless]

Attachment: fix

Comment 3

[John Gaunt (redfive)]

Comment on attachment 126130 [details] [diff] [review]
fix

These changes look fine, but put the constructor in the .h file compeletely so
it can be inlined. (like in tmTransaction.h)

with that r=jgaunt

Comment 4

[timeless]

checked in