210694 - build warnings in nsImapProtocol.cpp

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Henrik Gemal]

When I build nsImapProtocol.cpp on my gcc on Win32:

c:/mozilla/mozilla/mailnews/imap/src/nsImapProtocol.cpp: In member function
   `void nsImapProtocol::ProcessSelectedStateURL()':
c:/mozilla/mozilla/mailnews/imap/src/nsImapProtocol.cpp:1949: warning: unused
   variable `const char*hostName'
c:/mozilla/mozilla/mailnews/imap/src/nsImapProtocol.cpp: In member function
   `virtual void nsImapProtocol::NormalMessageEndDownload()':
c:/mozilla/mozilla/mailnews/imap/src/nsImapProtocol.cpp:3376: warning: compariso
n
   between signed and unsigned integer expressions
c:/mozilla/mozilla/mailnews/imap/src/nsImapProtocol.cpp: In member function
   `PRBool nsImapProtocol::CheckNeeded()':
c:/mozilla/mozilla/mailnews/imap/src/nsImapProtocol.cpp:7347: warning: compariso
n
   between signed and unsigned integer expressions

20030623

Comment 1

[David :Bienvenu]

Attachment: fix warnings

Comment 2

[David :Bienvenu]

fixed, r/sr=mscott

Comment 3

[Aleksey Nogin]

All the original warnings indeed went away, but there is a new one:

mailnews/imap/src/nsImapProtocol.cpp:3696
Unused variable `const PRInt32 kHdrsToFetchAtOnce'

It was introduced a few days ago by bug 103401 (all usages of the variable were
removed, but the variable stayed).