211193 - [FIXr] random array cleanup in exthandler

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Just a twinge of ugly code in my side.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 126801 [details] [diff] [review]
patch

+  nsILocalFile* localFile;

hm... why are you declaring this variable outside of the loop?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 126801 [details] [diff] [review]
patch

+  nsILocalFile* localFile;

hm... why are you declaring this variable outside of the loop?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Because that's where the original code had it, if you note....

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 126801 [details] [diff] [review]
patch

r=biesi if you move the "+  nsILocalFile* localFile;" declaration when this
variable is first used, to not make it look like this variable is used outside
the  |for|

Comment 6

[Alec Flett]

Comment on attachment 126801 [details] [diff] [review]
patch

nice. sr=alecf

Comment 7

[Boris Zbarsky [:bzbarsky]]

Checked in.