212284 - Adding a web site to allowed popup site list crashes Mozilla [@ nsPermissionManager::Add ]

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Jure Repinc (JLP)]

I'm using Mozilla 2003070908 on Windows XP with SP1. When I try to add some site
to a list of sites that are allowed to show popups Mozilla crashes. I sent 3
talkback reports: TB21772355E, TB21772352X, TB21772302H. I also noticed that
sites that are allowed to show popups are not listed in the Popup Manager.

Reproducable: allways

Steps to reproduce:
1. Open Mozilla
2. Go to Tools > Popup Manager > Manage popups
3. Enter some site. For example www.test.com
4. Click Add
5. Click OK

Actual result:
Mozilla crashes after clicking OK

Expected result:
Mozilla should add the site to the list and close the window.

Comment 1

[Olivier Cahagne]

wfm using build 2003070308 on Win2k, regression between 2003070308 and 2003070908.

Comment 2

[Frederic Bezies]

Seeing those crash on a current based CVS trunk build - Linux.

So, it seems to be an OS->All problem.

Comment 3

[David Bradley]

Attachment: Stack for talkback 21772352

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: ptrcheck and update caller

Forgot to check aType for a correct pointer. The popup manager used the old
nnumber version, instead of the string. Forgot to update that file.
Fixed that, and checking for a pointer now.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 127468 [details] [diff] [review]
ptrcheck and update caller

<dwitte_away> mvl: r=dwitte for the NS_ENSURE_ARG and caller fix.

Marking as such.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 127468 [details] [diff] [review]
ptrcheck and update caller

Requesting approval for this fix for a quite visible crash. That patch itself
is low-risk, mainly a few checks for correct pointers.

Comment 7

[[e-mail]]

-> mvl.

Comment 8

[[e-mail]]

fixed.