214824 - NSS build fails with Apple GCC 3.3

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Brian Ryner (not reading)]

Using Apple's gcc 3.3 release (either the update for Jaguar or one of the
Panther seeds), NSS fails to build with the following error:

secasn1.h:270: error: syntax error at '##' token

The reason is because NSS uses -traditional-cpp, which has changed to mean a
different thing (the standard GCC meaning, rather than Apple's earlier hacks). 
It should be using -no-cpp-precomp, which will have the desired effect.
-no-cpp-precomp has been supported for quite awhile, so it won't break any old
builds.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Wan-Teh Chang]

Comment on attachment 129045 [details] [diff] [review]
patch

r=wtc.	Should we make a similar change to NSPR?

Comment 3

[Brian Ryner (not reading)]

NSPR seems to already be using -no-cpp-precomp.  So, I think just the NSS patch
needs checked in.

Comment 4

[Wan-Teh Chang]

I checked in the patch on the NSS trunk (NSS 3.9),
NSS_3_8_BRANCH (NSS 3.8.2), and NSS_CLIENT_TAG
(Mozilla 1.6 alpha).