Closed
Bug 214824
Opened 22 years ago
Closed 21 years ago
NSS build fails with Apple GCC 3.3
Categories
(NSS :: Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.9
People
(Reporter: bryner, Assigned: wtc)
Details
(Whiteboard: [3.8.2])
Attachments
(1 file)
|
760 bytes,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
Using Apple's gcc 3.3 release (either the update for Jaguar or one of the
Panther seeds), NSS fails to build with the following error:
secasn1.h:270: error: syntax error at '##' token
The reason is because NSS uses -traditional-cpp, which has changed to mean a
different thing (the standard GCC meaning, rather than Apple's earlier hacks).
It should be using -no-cpp-precomp, which will have the desired effect.
-no-cpp-precomp has been supported for quite awhile, so it won't break any old
builds.
|
Reporter | |
Comment 1•22 years ago
|
||
|
|
Reporter | |
Updated•22 years ago
|
Attachment #129045 -
Flags: review?(wtc)
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 129045 [details] [diff] [review]
patch
r=wtc. Should we make a similar change to NSPR?
Attachment #129045 -
Flags: review?(wtc) → review+
|
|
Reporter | |
Comment 3•22 years ago
|
||
NSPR seems to already be using -no-cpp-precomp. So, I think just the NSS patch
needs checked in.
|
|
Assignee | |
Comment 4•21 years ago
|
||
I checked in the patch on the NSS trunk (NSS 3.9),
NSS_3_8_BRANCH (NSS 3.8.2), and NSS_CLIENT_TAG
(Mozilla 1.6 alpha).
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: [3.8.2]
Target Milestone: --- → 3.9
You need to log in
before you can comment on or make changes to this bug.
Description
•