220332 - Insecure dependency in exec while running with -T switch at process_bug.cgi line 1267.

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[Ralf Hauser]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030907
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030907

seems to be related to bug 177828

Reproducible: Didn't try

Steps to Reproduce:
1. add text and remove a cc in one change
2.
3.

Actual Results:  
no mails were sent out

Expected Results:  
mails should have been sent out

Comment 1

[Dave Miller [:justdave]]

What version of Bugzilla?

Comment 2

[Dave Miller [:justdave]]

confirmed on http://landfill.bugzilla.org/bugzilla-2.16-branch/

Comment 3

[Vlad Dascalu]

Attachment: Patch tainting securely removed emails

This should fix the issue. (I haven't managed to make sendmail work on my
localhost to properly test it that it solves the problem)

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 133023 [details] [diff] [review]
Patch tainting securely removed emails

requesting 2nd review

Comment 5

[Vlad Dascalu]

<-- me

Comment 6

[Matisse Enzer]

I applied the patch but when trying to remove a CC I get this in the Apache
error_log:

  Premature end of script headers: process_bug.cgi

Comment 7

[Matisse Enzer]

My bad.
The patch worked.

The problem I had was because I ran 'patch' as root, so the patched file was
owned by 'root' instead of nobody. Once I changed the ownership of
process_bug.cgi back to 'nobody' it worked.

I could complain that Apache should have given a better error mesage, but I
won't :-)

Comment 8

[Gervase Markham [:gerv]]

Comment on attachment 133023 [details] [diff] [review]
Patch tainting securely removed emails

r=gerv, on the basis that it is reported to have worked, and I can't see how
the patch can break anything.

Gerv

Comment 9

[Vlad Dascalu]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.125.2.8; previous revision: 1.125.2.7
done