Closed
Bug 220406
Opened 21 years ago
Closed 21 years ago
nsLocalFileWin::Launch should return more specific errors
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.6alpha
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
1.92 KB,
patch
|
dougt
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
msdn describes the specific error returns of ShellExecute
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #132220 -
Flags: superreview?(darin)
Attachment #132220 -
Flags: review?(dougt)
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.6alpha
Comment 2•21 years ago
|
||
Comment on attachment 132220 [details] [diff] [review] patch looks fine. thanks for the patch. r=dougt
Attachment #132220 -
Flags: review?(dougt) → review+
Comment 3•21 years ago
|
||
uhm... so how do you plan to make use of these error codes? what bug does this block? if you don't plan to use these error codes, then why add this code?
Comment 4•21 years ago
|
||
your not talking about alot of code. (14 branches and some overhead code).
Comment 5•21 years ago
|
||
Comment on attachment 132220 [details] [diff] [review] patch true, but it is still a valid question, right? ;-)
Attachment #132220 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Comment 6•21 years ago
|
||
I'm planning to use it in the ExternalHelperAppService code, to show users more friendly error messages when launching a helper application failed. bug is not yet filed, I will cc you.
Assignee | ||
Comment 7•21 years ago
|
||
Checking in nsLocalFileWin.cpp; /cvsroot/mozilla/xpcom/io/nsLocalFileWin.cpp,v <-- nsLocalFileWin.cpp new revision: 1.109; previous revision: 1.108 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•