220649 - No Theme Selection Not Available on CSS sites that don't offer alternate stylesheets

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[David Anderson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20030925 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20030925 Firebird/0.7

Going to a site that offers alternate style sheets in Thunderbird .7 is great... 
If I want, I can easily see how a the page might look in a non-css browser by
choosing the No Theme option in the Firebird Style Sheet Selector.

However, if I go to a site that is CSS-based, but happens not to offer a
alternate style sheet, the style selector is not available and the No Theme
option is, hence, = not available for selecting.

Can the Style Sheet Selector be available when I'm at a CSS-based page that
happens to not offer an alternate style sheet, then I could select No Theme on
those sites as well.

Ps. The Style Selector Extension currently offers such functionality and the
lack of No Theme selectability on non-alt style sites is the only reason I'm
using two practically duplicate components.

Thanks in advance.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Bill Mason]

You can do this by editing your userChrome.css  See
http://texturizer.net/firebird/tips.html#beh_stylesheetswitcher

Comment 2

[David Anderson]

I guess I'm still asking that this be default behavior...

thanks, though, I'll edit the userChrome and uninstall the extension

Comment 3

[Mike Connor [:mconnor]]

By design, not going to change it. (Most people don't want it always on, just
where there's actual alternate options)

Comment 4

[David P James]

Use the Pinball theme; I "fixed" this issue with 0.7.4. 
 
See bug 215801 (which will probably be WONTFIXED just as soon as Mike sees 
it :) ). Just note that we can display a different icon for pages that have 
alternate stylesheets as compared to those that don't. Being able to select 
"No Theme" is very useful when attempting to print a page with complex CSS. 
 
 

Comment 5

[Simon Paquet [:sipaq]]

verified wontfix

Comment 6

[fantasai]

Reopening. This bug is about making "no style" available when there is no
alternate style sheet defined, not about making the icon always present.

Comment 7

[fantasai]

Attachment: patch for testing

Comment 8

[fantasai]

Attachment: patch for check-in

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 157227 [details] [diff] [review]
patch for check-in

r+a=[e-mail]

Comment 10

[Ian Neal]

Checking in mozilla/browser/base/content/browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <-- 
browser-menubar.inc
new revision: 1.19.2.2.2.24; previous revision: 1.19.2.2.2.23
done

Checked into AVIARY_1_0_20040515_BRANCH

Comment 11

[Michael Lefevre]

Isn't this going to go into the trunk too?

Comment 12

[Asaf Romano (gone)]

Reopened for trunk

Comment 13

[fantasai]

Filed 257608 for trunk. Trunk fixes will need a new patch, this can't just be
checked-in as-is.