220734 - [pwd-mngr] Password Manager multiple identities problem with forms having value=""

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[David P James]

This is probably a regression from the checkin of bug 216395. This bug occurs on
pages where forms have a null value attribute (ie value="") and the user has
multiple usernames/logins for that form. The problem that presents itself is
that down arrowing before any characters have been typed does not always call up
the drop down list of logins, as it always does for login forms without value=""
and for all other forms with saved info. My personal experience is that this
issue only happens on the initial session when you enter the two logins;
restarting the browser fixes it for me but seemingly not for others (I'm seeing
this in both Linux and Win98).

If you type the first character of one of the logins the autocomplete dropdown
appears with entries matching the first letter, but that requires the user to
remember the first character of all logins everywhere.

A possible fix, suggested by Jesse Ruderman and which I like, is to
automatically generate the drop down list for logins with multiple user ids upon
page loading. That way the user can select the login from the dropdown with
either a cursor or a mouse without any fuss and without the focus-stealing
pop-up that we used to have.

I'll attach a test case shortly.

Comment 1

[David P James]

Attachment: Bugzilla login with value="" in the email address field

Test case. This bug is not 100% reproducible unfortunately.

Comment 2

[David P James]

-->Minor

I've had someone else check this and they get the same results as I do -
restarting the browser makes the problem go away.

If someone (1) can replicate this bug with this test case all the time or (2)
provide an example of website that does this all the time then I'll reconsider
the severity level.

Comment 3

[alanjstr]

I've seen this.  Hittine Escape will paste the clipboard into the username blank
(wtf?), but then enables the dropdown to show up when using the down arrow. 
Hitting escape again will clear the field.  

Comment 4

[alanjstr]

Confirmed Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031003
Firebird/0.7

Comment 5

[David P James]

Adding [pwd-mngr] to summary of Password Manager bugs to facilitate querying.
Sorry for the bugspam.

Comment 6

[tyl2]

On both iWon and Excite Mail's login pages, value="" exists, but autocomplete
doesn't appear even after restarting browser. I've never had the new pwd mgr
work on these site.

http://registration.iwon.com/reg/login.jsp
http://registration.excite.com/excitereg/login.jsp?ref=email&return_url=http://e13.email.excite.com

Not only that, but typing the first letter doesn't work either. I have to type
the whole user name then switch the password field. Needless to say, ****.

OK, I know someone who already switch back because of this. Please fix it asap.
I'd like to see it as more than a "minor" problem.

Comment 7

[Kipp Howard]

I don't know if this helps or not but my install of Firebird 0.7 was exhibiting
this problem, even on forms that did not have value="" attributes.  The
Esc-Esc-down arrow wasn't working either.  

Last night, I installed the following extensions and then the autocomplete
dropdown started working this morning (I was very pleased to see this):
	All-in-One Gestures
	Tabbrowser Extensions
	Bookmark Backup 0.2

I installed all of these into the Firebird folder (not in my profile)

I've since disabled all of these extensions, restarted and the autocomplete is
still present.  Sorry I didn't try this after installing each extension to try
and figure out which ones.

I also recreated my Firebird installation (without the extensions) and the
autocomplete dropdown still works.  I guess it has something to do with my
profile that was changed when I installed these Extensions.  

My wife's profile was having the same problem as mine so I switched to that one
and the new Firebird Installation would not show the autocomplete dropdown.  I
proceeded to install each extension and check to see if the autocomplete
dropdown would work.  It still didn't work after I installed each of them, so I
started configuring them as I did in my profile.  I first whet into the
Tabbrowse Extension Opetions and enabled the following on the "Advanced Startup"
page: 
	Open last visited page when browser starts up.

When I went to check on the Autocomplete dropdown, it worked!  If I disable that
setting, it still works.  Maybe just making any change fixes it or this specific
setting did it.  I don't know.

I wish I had saved a copy of a profile that doesn't work so that I could do a
diff between it and a working one.  Sorry.  Maybe someone else who is having
this problem can continue some of this testing (copy your profile first and then
do some diffs) to determine exactly what is causing this problem.

PS: I moved my Mozilla 1.4 passwords to Firebird 0.7 via the following:
http://texturizer.net/firebird/faq.html#mozpass 

Comment 8

[Kipp Howard]

I just found out that setting browser.startup.page preference to "0" will cause
this bug to show itself.  Setting that preference back to 1 will fix the problem. 
Can anyone else confirm this?

Again, this is with Firebird 0.7

Comment 9

[Kipp Howard]

I just installed the latest test version of Firebird 0.8 (03.01.04 - 02:59:00)
and tested to see if this bug has changed.

It appears that the fix that I mentioned in the last comment (setting
browser.startup.page to 1) doesn't fix this problem in 0.8.  No matter what I do
now, I can no longer get the password manager to show up (i.e., Esc-Esc-down).  

I can still type in the userid and the correct password shows up, but some
userids that I have are quite difficult to remember (lots of numbers).  This
makes getting into the site difficult (i.e., I have to have my planner next to
me that lists the userids and then I have to type them in by hand).

Comment 10

[alanjstr]

Testcase WFM Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7)
Gecko/20040614 Firefox/0.9

It starts out blank, but hitting the down arrow makes my two remembered values
appear.

Comment 11

[RobertJ]

*** Bug 259625 has been marked as a duplicate of this bug. ***

Comment 12

[RobertJ]

Just to clarify what I am seeing

For multiple name/passwords for the same site:

With 0.9.3 by hitting the down arrow you got choices (could also start to type)

With 1PR nothing with down arrow or typing. If you type in one of the names
completely and tab the correct password is filled in.

This never changes (so far).

Comment 13

[ralph]

I think this bug is more major than the comments indicated here.

One site that I log into frequenty http://www.news.earthlink.net/ and for which
I have multiple logins, shows a lot worse behavior than indicated here.

Runing with PR1, in more than 25 tries it has failed all but once.  When it
fails, I mean that I don't get any userid's - clicking, down arrow, typing first
characters, nothing. I have to type the entire login each time.  One time it did
work, and I have no idea whatsoever what was different about that time. 

Running Windows XP SP2.  I have autofill .2 extension installed, and 99% certain
this was failing before I installed the extension.

As noted by Robert Janc, when I type the userid, the password is entered
automatically and correctly

Comment 14

[Mike Schroepfer]

Minus for 1.8Beta since this is not a major flaw or regression.  We'll pick it
up on the next cycle.

Comment 15

[Osioke]

(In reply to comment #13)
> I think this bug is more major than the comments indicated here.
> 
> One site that I log into frequenty http://www.news.earthlink.net/ and for which
> I have multiple logins, shows a lot worse behavior than indicated here.
> 
> Runing with PR1, in more than 25 tries it has failed all but once.  When it
> fails, I mean that I don't get any userid's - clicking, down arrow, typing first
> characters, nothing. I have to type the entire login each time.  One time it did
> work, and I have no idea whatsoever what was different about that time. 
> 
> Running Windows XP SP2.  I have autofill .2 extension installed, and 99% certain
> this was failing before I installed the extension.
> 
> As noted by Robert Janc, when I type the userid, the password is entered
> automatically and correctly

Yes, this is more serious than it is being reported.  Out of 99 logins, only less than 5 provide a drop down list of usernames from which to select (whether by starting to type the username or clicking the down-arrow).  I almost always have to type the enitre username for the password to be entered automatically.

Will this be fixed ever?

Comment 16

[David P James]

Mass edit: Changing QA to default QA Contact

Comment 17

[Michael Wu [:mwu]]

Can this issue still be reproduced? It works fine here on bon echo/branch. (provided you give focus to the email addr field first before hitting down)

Comment 18

[Michael Wu [:mwu]]

Please reopen if there is a better test case that triggers this in either branch or trunk.

The pages in comment #6 have autocomplete disabled. We do not save passwords if the site asks us not to, and that's a different issue anyway. The attached testcase works for me. The page in comment #13 also works for me.