221598 - regression test pain relief

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Bernd]

on my new notebook I discovered that I had patched several files....

Comment 1

[Bernd]

Attachment: patch

Comment 3

[Bernd]

Attachment: patch

Comment 4

[Bernd]

Comment on attachment 132885 [details] [diff] [review]
patch

Boris, could you please verify that the tests run under linux with this patch

-B 1 dumps only the differing nodes and not the whole tree.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 132885 [details] [diff] [review]
patch


>  TESTS_FILE=`cygpath -w $TESTS_FILE`
>- MOZ_TEST_BASE=`cygpath -w $MOZ_TEST_BASE | sed -e 's|\\|/|g'`
> fi
>+MOZ_TEST_BASE=`echo $MOZ_TEST_BASE | sed -e"s,cygdrive/\(.\),\1:,"`
> cp /dev/null $TESTS_FILE
> 
> for FILE in `ls file_list.txt file_list[0-9].txt 2> /dev/null`; do

This is undoing a change that was made for a reason (configurable mount
points).  However, cygpath -w combined with sed could be replaced by cygpath
-m.

Comment 6

[Bernd]

this backout is simply http://bugzilla.mozilla.org/show_bug.cgi?id=158920#c27, I
am proposing to back out untested code that horks the regression tests.
cygpath -m does not work
viewer and mozilla do not accept something like this
file:///cygdrive/e/moz_src/mozilla/layout/html/tests/block/base/width-fixed.html
they need 
file:///e:/moz_src/mozilla/layout/html/tests/block/base/width-fixed.html

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That's odd.  Are you sure you're following the windows codepath rather than the
non-windows codepath?

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

If it's still the "unterminated s command" issue, you could just replace
MOZ_TEST_BASE=`cygpath -w $MOZ_TEST_BASE | sed -e 's|\\|/|g'`
with
MOZ_TEST_BASE=`cygpath -m $MOZ_TEST_BASE`

Comment 9

[Boris Zbarsky [:bzbarsky]]

bernd, do you want me to just apply the patch and run a baseline/verify cycle?

Also, as regards the cygpath change... no matter what it ends up being, keep it
in the win32 clause there.  Doing that replacement on Unix for no reason is not
cool.

Comment 10

[Bernd]

Attachment: revised patch with dbaron's and bz's comments

Boris, if you could run once the verify run that would be great.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132907 [details] [diff] [review]
revised patch with dbaron's and bz's comments

This runs fine on Linux, and the changes look reasonable to me.  As long as the
cygpath thing is doing the right thing, r=bzbarsky

Comment 12

[Adam D. Moss]

Oi oi, any chance of a more descriptive summary/report next time?

"regression test pain relief / on my new notebook I discovered
that I had patched several files" leaves me with pitifully little
idea of what issue this bug is trying to address.  (Besides being
puzzling, this makes it hard for helpers to verify or dup.)

Comment 13

[Bernd]

The layout regression tests have been severly broken. The patch brings the tests
somehow back to a level where they are useable under windows. The tests are not
part of the build. If you are wondering what the tests are about
http://lxr.mozilla.org/seamonkey/source/layout/doc/regression_tests.html. The
only person that I know who runs these tests these days under windows is
jkeiser, but I fixed the tests already on his machine.

Comment 14

[Adam D. Moss]

Thank you. :)

Comment 15

[Bernd]

fixed