221763 - XPTC_InvokeByIndex crashes when cross-compiled under GCC 3.x for target arm-linux

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P1)

Description

[Darin Fisher]

XPTC_InvokeByIndex crashes when cross-compiled under GCC 3.x for target arm-linux.

I have a patch which fixes this.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Darin Fisher]

so, the existing code just happens to work when compiled using GCC 2.95 ... i
think it magically chooses not to use $sp for other things.  GCC 3.3.1 on the
other hand decides to make use of $sp to reference some stuff, and that makes
things go to hell in a hurry.  the fix is simple: tell GCC that we are using $sp
for specific things.  as a result GCC uses $r5 instead, and things are happy :)

Comment 3

[timeless]

Comment on attachment 132980 [details] [diff] [review]
v1 patch

sp is clearly used,
this is the right thing (tm)

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 132980 [details] [diff] [review]
v1 patch

Agreed!

Comment 5

[Darin Fisher]

fixed-on-trunk ... thx for the quick reviews guys!